improvement: Improve error messages when creating ColumnDefinitions with improper arguments

Avoid using the "you" pronoun.

Author: nwoltman

lib/ColumnDefinitions/index.js

@@ -77,8 +77,8 @@ const ColumnDefinitions = {
     return new TextColumnDefinition('char', m);
   },
   varchar(m) {
-    if (m === null || m === undefined) {
-      throw new Error('You must specify the `m` argument for varchar');
+    if (m === undefined) {
+      throw new Error('The varchar `m` argument must be specified');
     }
     return new TextColumnDefinition('varchar', m);
   },
@@ -98,8 +98,8 @@ const ColumnDefinitions = {
     return new ColumnDefinition('binary', m);
   },
   varbinary(m) {
-    if (m === null || m === undefined) {
-      throw new Error('You must specify the `m` argument for varbinary');
+    if (m === undefined) {
+      throw new Error('The varbinary `m` argument must be specified');
     }
     return new ColumnDefinition('varbinary', m);
   },
@@ -117,13 +117,13 @@ const ColumnDefinitions = {
   },
   enum(...values) {
     if (values.length === 0) {
-      throw new Error('You must provide at least one possible enum value');
+      throw new Error('At least one enum value must be provided');
     }
     return new TextColumnDefinition('enum', values);
   },
   set(...values) {
     if (values.length === 0) {
-      throw new Error('You must provide at least one possible set value');
+      throw new Error('At least one set value must be provided');
     }
     return new TextColumnDefinition('set', values);
   },

test/unit/ColumnDefinitions.test.js

@@ -547,8 +547,8 @@ describe('ColumnDefinitions', () => {
   describe('varchar and varbinary', () => {
 
     it('should throw if no `m` value is provided when creating the column definition', () => {
-      should.throws(() => ColumnDefinitions.varchar(), /You must specify the `m` argument for varchar/);
-      should.throws(() => ColumnDefinitions.varbinary(), /You must specify the `m` argument for varbinary/);
+      should.throws(() => ColumnDefinitions.varchar(), 'The varchar `m` argument must be specified');
+      should.throws(() => ColumnDefinitions.varbinary(), 'The varbinary `m` argument must be specified');
     });
 
     it('should accept 0 as a valid `m` value', () => {
@@ -576,8 +576,8 @@ describe('ColumnDefinitions', () => {
     });
 
     it('should throw if no values are provided when creating the column definition', () => {
-      should.throws(() => ColumnDefinitions.enum(), /provide at least one possible enum value/);
-      should.throws(() => ColumnDefinitions.set(), /provide at least one possible set value/);
+      should.throws(() => ColumnDefinitions.enum(), 'At least one enum value must be provided');
+      should.throws(() => ColumnDefinitions.set(), 'At least one set value must be provided');
     });
 
   });