MySQLTable: Simplify parsing arguments to .insert() and .update()

Author: nwoltman

lib/MySQLTable.js

@@ -154,17 +154,13 @@ class MySQLTable {
       );
     }
 
-    if (cb) {
-      sqlString = this._db.format(sqlString, values);
-    } else if (values) {
-      if (typeof values === 'function') {
-        cb = values;
-      } else {
+    if (typeof sqlString === 'string') {
+      if (typeof values === 'object') {
         sqlString = this._db.format(sqlString, values);
+      } else {
+        cb = values;
       }
-    } else if (sqlString === undefined) {
-      sqlString = '';
-    } else if (typeof sqlString === 'function') {
+    } else {
       cb = sqlString;
       sqlString = '';
     }
@@ -234,17 +230,13 @@ class MySQLTable {
       );
     }
 
-    if (cb) {
-      sqlString = this._db.format(sqlString, values);
-    } else if (values) {
-      if (typeof values === 'function') {
-        cb = values;
-      } else {
+    if (typeof sqlString === 'string') {
+      if (typeof values === 'object') {
         sqlString = this._db.format(sqlString, values);
+      } else {
+        cb = values;
       }
-    } else if (sqlString === undefined) {
-      sqlString = '';
-    } else if (typeof sqlString === 'function') {
+    } else {
       cb = sqlString;
       sqlString = '';
     }