refactor: Use Array.isArray() instead of instanceof Array

nwoltman · nwoltman · commit 4e73a2ea6e03 · 2019-11-02T12:30:28.000-04:00
It's faster in newer versions of V8.
diff --git a/lib/MySQLTable.js b/lib/MySQLTable.js
@@ -236,7 +236,7 @@ class MySQLTable {
       sqlString = '';
     }
 
-    if (data instanceof Array) {
+    if (Array.isArray(data)) {
       data = data.length > 1
         ? ' (' + this._db.escapeId(data[0]) + ') VALUES ' + this._db.escape(data[1])
         : ' VALUES ' + this._db.escape(data[0]);

Original file line number	Diff line number	Diff line change
`@@ -236,7 +236,7 @@ class MySQLTable {`
`236`	`236`	`sqlString = '';`
`237`	`237`	`}`
`238`	`238`
`239`		`- if (data instanceof Array) {`
	`239`	`+ if (Array.isArray(data)) {`
`240`	`240`	`data = data.length > 1`
`241`	`241`	`? ' (' + this._db.escapeId(data[0]) + ') VALUES ' + this._db.escape(data[1])`
`242`	`242`	`: ' VALUES ' + this._db.escape(data[0]);`