Skip to content

Conversation

@nvsukhanov
Copy link
Owner

  • fix format check&write commands
  • disable eslint rules conflicting w/ the prettier

+ fix format check&write commands
+ disable eslint rules conflicting w/ the prettier
@nvsukhanov nvsukhanov requested a review from Copilot March 29, 2025 11:53
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enforces a 120-symbol maximum line length across various components and resolves conflicts between ESLint and Prettier by reformatting JSX and TypeScript code.

  • Reformatted component props and JSX attributes into multi-line structures
  • Adjusted function declarations and constructor parameters for improved readability

Reviewed Changes

Copilot reviewed 125 out of 130 changed files in this pull request and generated no comments.

Show a summary per file
File Description
apps/toolbox/src/Components/SpeedInput/SpeedInput.tsx Reformatted props declaration and input element into multiple lines
apps/toolbox/src/Components/ServoOptionsForm/ServoOptionsForm.tsx Reformatted props and callback declarations, and reformatted JSX for better readability
apps/toolbox/src/Components/PowerInput/PowerInput.tsx Split input element into multi-line layout
apps/toolbox/src/Components/PortIdInput/PortIdInput.tsx Reformatted props declaration for clarity
apps/toolbox/src/Components/NoFeedbackToggle/NoFeedbackToggle.tsx Props declaration reorganized for improved readability
apps/toolbox/src/Components/Nav/Nav.tsx Converted inline JSX to multi-line format for nav items and button elements
apps/toolbox/src/Components/MotorUseProfileSelect/MotorUseProfileSelect.tsx Reformatted object literal for consistency
apps/toolbox/src/Components/ModeIdInput/ModeIdInput.tsx Reformatted props declaration and input element into multiple lines
apps/toolbox/src/Components/ColorInput/ColorInput.tsx Reformatted input elements into multi-line blocks
apps/toolbox/src/Components/BluetoothIsUnavailableNotification/BluetoothIsUnavailableNotification.tsx Adjusted spacing in JSX for consistency
apps/toolbox/src/Common/Di/DiContainer.tsx Reformatted function parameters and props declaration for improved readability
apps/toolbox/src/App/store-logger.ts Split constructor parameter formatting into multiple lines
apps/toolbox/src/App/Footer/Footer.tsx Converted inline content of section element to multi-line format
apps/toolbox/src/App/App.tsx Reformatted middleware instantiations into multi-line structure
apps/examples/node/src/port-value.ts Reformatted RxJS pipe chain into multi-line for clarity
Files not reviewed (5)
  • .editorconfig: Language not supported
  • .prettierrc: Language not supported
  • apps/examples/browser/hub-properties.html: Language not supported
  • apps/examples/browser/pf-motor-power.html: Language not supported
  • apps/examples/browser/port-value.html: Language not supported

@cloudflare-workers-and-pages
Copy link

Deploying rxpoweredup with  Cloudflare Pages  Cloudflare Pages

Latest commit: ecbc7b8
Status: ✅  Deploy successful!
Preview URL: https://7b54f0f4.rxpoweredup.pages.dev
Branch Preview URL: https://enforce-120-line-length.rxpoweredup.pages.dev

View logs

@nvsukhanov nvsukhanov merged commit 01a5751 into main Mar 29, 2025
2 checks passed
@nvsukhanov nvsukhanov deleted the enforce-120-line-length branch March 29, 2025 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants