Manually control assembly version

Switched the build process over so that MSBuild no longer auto-generates the assembly version. Instead, we pass it to MSBuild with the `Version` parameter.

Author: gbakeman

.github/workflows/build-solution.yaml

@@ -13,7 +13,7 @@ on:
         type: string
 
       version:
-        description: 'Version number to refer to this build and its assets, in `v.major.minor.build`.'
+        description: 'Version number to refer to this build and its assets, in the form `major.minor.build`.'
         required: true
         type: string
   workflow_call:
@@ -24,7 +24,7 @@ on:
         type: string
 
       version:
-        description: 'Version number to refer to this build and its assets, in `v.major.minor.build`.'
+        description: 'Version number to refer to this build and its assets, in the form `major.minor.build`.'
         required: true
         type: string
 
@@ -46,8 +46,6 @@ jobs:
     strategy:
       matrix:
         os: [windows-latest]
-    outputs:
-      asmVersion: ${{ steps.getversion.outputs.version }}
     steps:
     # Build output goes in this runner's temp directory
     - name: Get output directory
@@ -65,19 +63,16 @@ jobs:
 
     # msbuild cannot handle .vdproj Installer projects, so only build debug for now.
     - name: Build solution
-      run: msbuild $env:SLN_DIR\$env:SLN_FILE -nologo -property:Configuration=${{ inputs.buildMode }} -property:OutDir=${{ env.OUTPUT }}
-
-    # For now, let msbuild continue autogenerating assembly versions and base everything off of that.
-    - name: Get AssemblyVersion generated by msbuild
-      id: getversion
-      uses: berglie/assembly-version/get@v1
-      with:
-        directory: ${{ env.OUTPUT }}
+      run: >
+        msbuild $env:SLN_DIR\$env:SLN_FILE -nologo
+        -property:Configuration=${{ inputs.buildMode }}
+        -property:OutDir=${{ env.OUTPUT }}
+        -property:Version=${{ inputs.version }}
 
     - name: Upload Artifact
       uses: actions/upload-artifact@v3
       with:
-        name: ${{ format('winnut-client-{0}-{1}', inputs.buildMode, vars.GITHUB_WORKFLOW_SHA) }}
+        name: ${{ format('winnut-client-{0}-{1}', inputs.buildMode, inputs.version) }}
         if-no-files-found: error
         path: ${{ env.OUTPUT }}
 

WinNUT_V2/SharedAssemblyInfo.vb

@@ -20,17 +20,4 @@ Imports System.Reflection
 <Assembly: AssemblyProduct("WinNUT Client")>
 <Assembly: AssemblyCopyright("NUTDotNet contributors © 2019-2022")>
 <Assembly: AssemblyTrademark("https://github.com/nutdotnet/WinNUT-Client")>
-
-' Les informations de version pour un assembly se composent des quatre valeurs suivantes :
-'
-'      Version principale
-'      Version secondaire
-'      Numéro de build
-'      Révision
-'
-' Vous pouvez spécifier toutes les valeurs ou indiquer les numéros de build et de révision par défaut
-' en utilisant '*', comme indiqué ci-dessous :
-' <Assembly: AssemblyVersion("1.0.*")>
-
-<Assembly: AssemblyVersion("2.2.*")>
 <Assembly: NeutralResourcesLanguage("en-US")>

WinNUT_V2/WinNUT-Client/WinNUT-client.vbproj

@@ -27,6 +27,7 @@
     <MapFileExtensions>true</MapFileExtensions>
     <ApplicationRevision>1</ApplicationRevision>
     <ApplicationVersion>2.2.0.%2a</ApplicationVersion>
+    <Version Condition="'$(Version)' == ''">0.0.0.0</Version>
     <UseApplicationTrust>false</UseApplicationTrust>
     <PublishWizardCompleted>true</PublishWizardCompleted>
     <BootstrapperEnabled>true</BootstrapperEnabled>
@@ -44,6 +45,8 @@
     <DocumentationFile>WinNUT-Client.xml</DocumentationFile>
     <NoWarn>42016,41999,42017,42018,42019,42032,42036,42020,42021,42022</NoWarn>
     <Optimize>false</Optimize>
+    <DefineConstants>
+    </DefineConstants>
   </PropertyGroup>
   <PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Release|AnyCPU' ">
     <PlatformTarget>AnyCPU</PlatformTarget>
@@ -407,4 +410,16 @@
   <Target Name="MATPrerequisite" BeforeTargets="PrepareForBuild" Condition="!Exists('$(MSBuildExtensionsPath)\Microsoft\Multilingual App Toolkit\Microsoft.Multilingual.ResxResources.targets')" Label="MultilingualAppToolkit">
     <Warning Text="$(MSBuildProjectFile) is Multilingual build enabled, but the Multilingual App Toolkit is unavailable during the build. If building with Visual Studio, please check to ensure that toolkit is properly installed." />
   </Target>
+  <Target Name="BeforeBuild">
+    <ItemGroup>
+      <AssemblyAttributes Include="AssemblyVersion">
+        <_Parameter1>$(Version)</_Parameter1>
+      </AssemblyAttributes>
+    </ItemGroup>
+    <MakeDir Directories="$(IntermediateOutputPath)" />
+    <WriteCodeFragment Language="VB" OutputFile="$(IntermediateOutputPath)Version.cs" AssemblyAttributes="@(AssemblyAttributes)" />
+    <ItemGroup>
+      <Compile Include="$(IntermediateOutputPath)Version.cs" />
+    </ItemGroup>
+  </Target>
 </Project>