Relocate artifact upload step out of workflows

Artifact uploading occurs in the build solution action now, directly after compilation happens. This should simplify calling workflows. Testing the change in debug only for now.

Author: gbakeman

.github/actions/build-solution/action.yaml

@@ -1,5 +1,5 @@
 name: "Build Solution"
-description: "Execute MSBuild with desired settings."
+description: "Execute MSBuild with desired settings, and upload resulting artifact."
 inputs:
       build-mode:
         description: 'Solution build mode passed to MSBuild.'
@@ -9,28 +9,28 @@ inputs:
         description: 'Version number to refer to this build and its assets, in the form `major.minor.build`.'
         required: true
 
-      compile-langs:
-        description: 'Install the Multilingual App Toolkit extension, so that languages are compiled.'
-        required: true
-
 runs:
   using: "composite"
   steps:
+    - name: "Get Short SHA"
+      shell: pwsh
+      run: echo "SHORT_SHA=$("${{ github.sha }}".SubString(0, 8))" >> $env:GITHUB_ENV
     - name: Setup MSBuild
       uses: microsoft/setup-msbuild@v1
     - name: Restore Packages
       working-directory: WinNUT_V2
       shell: pwsh
       run: msbuild $env:SLN_DIR -t:restore
-    - name: Install Multilingual App Toolkit extension
-      if: inputs.compile-langs == 'true'
-      uses: microcompiler/install-vsix@db1f973c3d24d1ddc0c38f14d0e1e3a85b2ccb21
-      with:
-        packagename: 'dts-publisher.mat2022'
     - name: Build solution
       shell: pwsh
       working-directory: WinNUT_V2
       run: >
         msbuild WinNUT_V2.sln -nologo
         -property:Configuration=${{ inputs.build-mode }}
-        -property:Version=${{ inputs.version }}
+        -property:Version=${{ inputs.version }}
+    - name: Package output
+      uses: actions/upload-artifact@v3
+      with:
+        name: ${{ format('winnut-client-{0}-{1}', inputs.build-mode, env.SHORT_SHA) }}
+        if-no-files-found: error
+        path: WinNUT_V2/WinNUT-Client/bin/${{ inputs.build-mode }}

.github/workflows/build-debug.yaml

@@ -4,33 +4,19 @@ on:
   workflow_dispatch:
 
   pull_request:
-    branches: [ Dev-2.2 ] # Debug builds for PRs that target the dev branch.
+    branches: Dev-2.2
     paths:
     - '**.vb'
     - '**.vbproj'
 
-env:
-  SHORT_SHA:
-
 jobs:
   build-debug:
     runs-on: windows-latest
     steps:
-      - name: "Get Short SHA"
-        id: "get-short-sha"
-        shell: pwsh
-        run: echo "SHORT_SHA=$("${{ github.sha }}".SubString(0, 8))" >> $env:GITHUB_ENV
       - name: Checkout code
         uses: actions/checkout@v3
-      - name: Build solution in Debug configuration (no multilingual)
+      - name: Build solution in Debug configuration
         uses: ./.github/actions/build-solution
         with:
           build-mode: "Debug"
-          version: "2.2.*"
-          compile-langs: false
-      - name: Package output
-        uses: actions/upload-artifact@v3
-        with:
-          name: ${{ format('winnut-client-debug-{0}', env.SHORT_SHA) }}
-          if-no-files-found: error
-          path: WinNUT_V2/WinNUT-Client/bin/Debug
+          version: "${{ vars.PRERELEASE_VERSION }}.*"