fix: Include correct field name in registry preflight check results (#1194)

**What problem does this PR solve?**:
The registry check was returning the wrong field in some cases.

**Which issue(s) this PR fixes**:
Fixes #

**How Has This Been Tested?**:
<!--
Please describe the tests that you ran to verify your changes.
Provide output from the tests and any manual steps needed to replicate
the tests.
-->

**Special notes for your reviewer**:
<!--
Use this to provide any additional information to the reviewers.
This may include:
- Best way to review the PR.
- Where the author wants the most review attention on.
- etc.
-->

Author: dlipovetsky

pkg/webhook/preflight/generic/registry.go

@@ -22,8 +22,6 @@ import (
 	"github.com/nutanix-cloud-native/cluster-api-runtime-extensions-nutanix/pkg/webhook/preflight"
 )
 
-var registryMirrorVarPath = "cluster.spec.topology.variables[.name=clusterConfig].value.globalImageRegistryMirror"
-
 type registryCheck struct {
 	field                 string
 	kclient               ctrlclient.Client
@@ -81,8 +79,8 @@ func (r *registryCheck) checkRegistry(
 		result.Error = true
 		result.Causes = append(result.Causes,
 			preflight.Cause{
-				Message: fmt.Sprintf("failed to parse registry url %s with error : %s", registryURL, err),
-				Field:   registryMirrorVarPath,
+				Message: fmt.Sprintf("failed to parse registry url %s with error: %s", registryURL, err),
+				Field:   r.field + ".url",
 			},
 		)
 		return result
@@ -106,7 +104,7 @@ func (r *registryCheck) checkRegistry(
 			result.Causes = append(result.Causes,
 				preflight.Cause{
 					Message: fmt.Sprintf("failed to get Registry credentials Secret: %s", err),
-					Field:   fmt.Sprintf("%s.credentials.secretRef", registryMirrorVarPath),
+					Field:   r.field + ".credentials.secretRef",
 				},
 			)
 			return result
@@ -134,7 +132,7 @@ func (r *registryCheck) checkRegistry(
 		result.Causes = append(result.Causes,
 			preflight.Cause{
 				Message: fmt.Sprintf("failed to create a client to verify registry configuration %s", err.Error()),
-				Field:   registryMirrorVarPath,
+				Field:   r.field,
 			},
 		)
 		return result
@@ -145,7 +143,7 @@ func (r *registryCheck) checkRegistry(
 		result.Causes = append(result.Causes,
 			preflight.Cause{
 				Message: pingFailedReasonString(registryURL, err),
-				Field:   registryMirrorVarPath,
+				Field:   r.field,
 			},
 		)
 		return result

pkg/webhook/preflight/generic/registry_test.go

@@ -63,6 +63,7 @@ func (m *mockK8sClient) Get(
 func TestRegistryCheck(t *testing.T) {
 	testCases := []struct {
 		name                       string
+		field                      string
 		registryMirror             *carenv1.GlobalImageRegistryMirror
 		imageRegistry              *carenv1.ImageRegistry
 		kclient                    ctrlclient.Client
@@ -109,7 +110,8 @@ func TestRegistryCheck(t *testing.T) {
 			},
 		},
 		{
-			name: "registry mirror with invalid credentials secret",
+			name:  "registry mirror with invalid credentials secret",
+			field: "cluster.spec.topology.variables[.name=clusterConfig].value.globalImageRegistryMirror",
 			registryMirror: &carenv1.GlobalImageRegistryMirror{
 				URL: testRegistryURL,
 				Credentials: &carenv1.RegistryCredentials{
@@ -140,7 +142,8 @@ func TestRegistryCheck(t *testing.T) {
 			},
 		},
 		{
-			name: "registry mirror ping failure",
+			name:  "registry mirror ping failure",
+			field: "cluster.spec.topology.variables[.name=clusterConfig].value.globalImageRegistryMirror",
 			registryMirror: &carenv1.GlobalImageRegistryMirror{
 				URL: testRegistryURL,
 			},
@@ -209,6 +212,7 @@ func TestRegistryCheck(t *testing.T) {
 
 			// Create the check
 			check := &registryCheck{
+				field:                 tc.field,
 				kclient:               tc.kclient,
 				cluster:               cluster,
 				regClientPingerGetter: tc.mockRegClientPingerFactory,