feat: update handler version (#1144)

**What problem does this PR solve?**:
Updating the handler version and removing the previous
`controlplanevirtualip/providers/kubevip.go` handler implementation.

**Which issue(s) this PR fixes**:
Fixes #

**How Has This Been Tested?**:
<!--
Please describe the tests that you ran to verify your changes.
Provide output from the tests and any manual steps needed to replicate
the tests.
-->

**Special notes for your reviewer**:
<!--
Use this to provide any additional information to the reviewers.
This may include:
- Best way to review the PR.
- Where the author wants the most review attention on.
- etc.
-->

Author: dkoshkin

README.md

@@ -18,6 +18,14 @@ When adding a new handler, or modifying an existing one, pay close attention to
 when a new version of this extension is deployed in the management cluster,
 and avoid rollouts of Machines in those existing clusters.
 
+If a change to a handler is unavoidable, you must:
+
+1. Update the version of the handlers, e.g. from `v4` to `v5`.
+   This is done by updating the `..ClusterV4ConfigPatch` in the handler files in `pkg/handlers/../mutation/`.
+   And `..clusterv4configpatch` in `hack/examples/overlays/clusterclasses/../kustomization.yaml.tmpl`
+2. Update the version of the handler in the `pkg/handlers/v3` package, e.g. from `v3` to `v4`.
+3. Copy the existing implementation of the handler to `pkg/handlers/../v4/`.
+
 During CAPI provider upgrades, and periodically, all managed clusters are reconciled and mutation handler patches
 are applied.
 Any new handlers that return a new set of patches, or updated handlers that return a different set of patches,

charts/cluster-api-runtime-extensions-nutanix/defaultclusterclasses/aws-cluster-class.yaml

@@ -23,11 +23,11 @@ spec:
   patches:
   - external:
       discoverVariablesExtension: awsclusterconfigvars-dv.cluster-api-runtime-extensions-nutanix
-      generateExtension: awsclusterv3configpatch-gp.cluster-api-runtime-extensions-nutanix
+      generateExtension: awsclusterv4configpatch-gp.cluster-api-runtime-extensions-nutanix
     name: cluster-config
   - external:
       discoverVariablesExtension: awsworkerconfigvars-dv.cluster-api-runtime-extensions-nutanix
-      generateExtension: awsworkerv3configpatch-gp.cluster-api-runtime-extensions-nutanix
+      generateExtension: awsworkerv4configpatch-gp.cluster-api-runtime-extensions-nutanix
     name: worker-config
   - definitions:
     - jsonPatches:

charts/cluster-api-runtime-extensions-nutanix/defaultclusterclasses/docker-cluster-class.yaml

@@ -31,11 +31,11 @@ spec:
   patches:
   - external:
       discoverVariablesExtension: dockerclusterconfigvars-dv.cluster-api-runtime-extensions-nutanix
-      generateExtension: dockerclusterv3configpatch-gp.cluster-api-runtime-extensions-nutanix
+      generateExtension: dockerclusterv4configpatch-gp.cluster-api-runtime-extensions-nutanix
     name: cluster-config
   - external:
       discoverVariablesExtension: dockerworkerconfigvars-dv.cluster-api-runtime-extensions-nutanix
-      generateExtension: dockerworkerv3configpatch-gp.cluster-api-runtime-extensions-nutanix
+      generateExtension: dockerworkerv4configpatch-gp.cluster-api-runtime-extensions-nutanix
     name: worker-config
   workers:
     machineDeployments:

charts/cluster-api-runtime-extensions-nutanix/defaultclusterclasses/nutanix-cluster-class.yaml

@@ -74,11 +74,11 @@ spec:
   patches:
   - external:
       discoverVariablesExtension: nutanixclusterconfigvars-dv.cluster-api-runtime-extensions-nutanix
-      generateExtension: nutanixclusterv3configpatch-gp.cluster-api-runtime-extensions-nutanix
+      generateExtension: nutanixclusterv4configpatch-gp.cluster-api-runtime-extensions-nutanix
     name: cluster-config
   - external:
       discoverVariablesExtension: nutanixworkerconfigvars-dv.cluster-api-runtime-extensions-nutanix
-      generateExtension: nutanixworkerv3configpatch-gp.cluster-api-runtime-extensions-nutanix
+      generateExtension: nutanixworkerv4configpatch-gp.cluster-api-runtime-extensions-nutanix
     name: worker-config
   workers:
     machineDeployments:

docs/content/getting-started/integrating-with-your-clusterclass/_index.md

@@ -21,11 +21,11 @@ The required values are shown below per provider.
   patches:
   - external:
       discoverVariablesExtension: awsclusterconfigvars.cluster-api-runtime-extensions-nutanix
-      generateExtension: awsclusterv3configpatch.cluster-api-runtime-extensions-nutanix
+      generateExtension: awsclusterv4configpatch.cluster-api-runtime-extensions-nutanix
     name: cluster-config
   - external:
       discoverVariablesExtension: awsworkerconfigvars.cluster-api-runtime-extensions-nutanix
-      generateExtension: awsworkerv3configpatch.cluster-api-runtime-extensions-nutanix
+      generateExtension: awsworkerv4configpatch.cluster-api-runtime-extensions-nutanix
     name: worker-config
 ```
 
@@ -35,11 +35,11 @@ The required values are shown below per provider.
   patches:
   - external:
       discoverVariablesExtension: nutanixclusterconfigvars.cluster-api-runtime-extensions-nutanix
-      generateExtension: nutanixclusterv3configpatch.cluster-api-runtime-extensions-nutanix
+      generateExtension: nutanixclusterv4configpatch.cluster-api-runtime-extensions-nutanix
     name: cluster-config
   - external:
       discoverVariablesExtension: nutanixworkerconfigvars.cluster-api-runtime-extensions-nutanix
-      generateExtension: nutanixworkerv3configpatch.cluster-api-runtime-extensions-nutanix
+      generateExtension: nutanixworkerv4configpatch.cluster-api-runtime-extensions-nutanix
     name: worker-config
 ```
 
@@ -49,11 +49,11 @@ The required values are shown below per provider.
   patches:
   - external:
       discoverVariablesExtension: dockerclusterconfigvars.cluster-api-runtime-extensions-nutanix
-      generateExtension: dockerclusterv3configpatch.cluster-api-runtime-extensions-nutanix
+      generateExtension: dockerclusterv4configpatch.cluster-api-runtime-extensions-nutanix
     name: cluster-config
   - external:
       discoverVariablesExtension: dockerworkerconfigvars.cluster-api-runtime-extensions-nutanix
-      generateExtension: dockerworkerv3configpatch.cluster-api-runtime-extensions-nutanix
+      generateExtension: dockerworkerv4configpatch.cluster-api-runtime-extensions-nutanix
     name: worker-config
 ```
 
@@ -63,7 +63,7 @@ The required values are shown below per provider.
   patches:
   - external:
       discoverVariablesExtension: genericclusterconfigvars.cluster-api-runtime-extensions-nutanix
-      generateExtension: genericclusterv3configpatch.cluster-api-runtime-extensions-nutanix
+      generateExtension: genericclusterv4configpatch.cluster-api-runtime-extensions-nutanix
     name: cluster-config
 ```
 

hack/examples/overlays/clusterclasses/aws/kustomization.yaml.tmpl

@@ -19,11 +19,11 @@ patches:
         value:
           - name: "cluster-config"
             external:
-              generateExtension: "awsclusterv3configpatch-gp.cluster-api-runtime-extensions-nutanix"
+              generateExtension: "awsclusterv4configpatch-gp.cluster-api-runtime-extensions-nutanix"
               discoverVariablesExtension: "awsclusterconfigvars-dv.cluster-api-runtime-extensions-nutanix"
           - name: "worker-config"
             external:
-              generateExtension: "awsworkerv3configpatch-gp.cluster-api-runtime-extensions-nutanix"
+              generateExtension: "awsworkerv4configpatch-gp.cluster-api-runtime-extensions-nutanix"
               discoverVariablesExtension: "awsworkerconfigvars-dv.cluster-api-runtime-extensions-nutanix"
           - name: identityRef
             definitions:

hack/examples/overlays/clusterclasses/docker/kustomization.yaml.tmpl

@@ -19,11 +19,11 @@ patches:
         value:
           - name: "cluster-config"
             external:
-              generateExtension: "dockerclusterv3configpatch-gp.cluster-api-runtime-extensions-nutanix"
+              generateExtension: "dockerclusterv4configpatch-gp.cluster-api-runtime-extensions-nutanix"
               discoverVariablesExtension: "dockerclusterconfigvars-dv.cluster-api-runtime-extensions-nutanix"
           - name: "worker-config"
             external:
-              generateExtension: "dockerworkerv3configpatch-gp.cluster-api-runtime-extensions-nutanix"
+              generateExtension: "dockerworkerv4configpatch-gp.cluster-api-runtime-extensions-nutanix"
               discoverVariablesExtension: "dockerworkerconfigvars-dv.cluster-api-runtime-extensions-nutanix"
 
   # BEGIN CIS patches

hack/examples/overlays/clusterclasses/nutanix/kustomization.yaml.tmpl

@@ -19,11 +19,11 @@ patches:
         value:
           - name: "cluster-config"
             external:
-              generateExtension: "nutanixclusterv3configpatch-gp.cluster-api-runtime-extensions-nutanix"
+              generateExtension: "nutanixclusterv4configpatch-gp.cluster-api-runtime-extensions-nutanix"
               discoverVariablesExtension: "nutanixclusterconfigvars-dv.cluster-api-runtime-extensions-nutanix"
           - name: "worker-config"
             external:
-              generateExtension: "nutanixworkerv3configpatch-gp.cluster-api-runtime-extensions-nutanix"
+              generateExtension: "nutanixworkerv4configpatch-gp.cluster-api-runtime-extensions-nutanix"
               discoverVariablesExtension: "nutanixworkerconfigvars-dv.cluster-api-runtime-extensions-nutanix"
 
   # BEGIN CIS patches

pkg/handlers/aws/handlers.go

@@ -12,7 +12,7 @@ import (
 	awsmutation "github.com/nutanix-cloud-native/cluster-api-runtime-extensions-nutanix/pkg/handlers/aws/mutation"
 	awsworkerconfig "github.com/nutanix-cloud-native/cluster-api-runtime-extensions-nutanix/pkg/handlers/aws/workerconfig"
 	"github.com/nutanix-cloud-native/cluster-api-runtime-extensions-nutanix/pkg/handlers/options"
-	v2awsmutation "github.com/nutanix-cloud-native/cluster-api-runtime-extensions-nutanix/pkg/handlers/v2/aws/mutation"
+	awsmutationvprev "github.com/nutanix-cloud-native/cluster-api-runtime-extensions-nutanix/pkg/handlers/v3/aws/mutation"
 )
 
 type Handlers struct{}
@@ -28,9 +28,9 @@ func (h *Handlers) AllHandlers(mgr manager.Manager) []handlers.Named {
 		awsclusterconfig.NewVariable(),
 		awsworkerconfig.NewVariable(),
 		awsmutation.MetaPatchHandler(mgr),
-		v2awsmutation.MetaPatchHandler(mgr),
+		awsmutationvprev.MetaPatchHandler(mgr),
 		awsmutation.MetaWorkerPatchHandler(mgr),
-		v2awsmutation.MetaWorkerPatchHandler(mgr),
+		awsmutationvprev.MetaWorkerPatchHandler(mgr),
 	}
 }
 

pkg/handlers/aws/mutation/metapatch_handler.go

@@ -35,7 +35,7 @@ func MetaPatchHandler(mgr manager.Manager) handlers.Named {
 	patchHandlers = append(patchHandlers, genericmutation.ControlPlaneMetaMutators()...)
 
 	return mutation.NewMetaGeneratePatchesHandler(
-		"awsClusterV3ConfigPatch",
+		"awsClusterV4ConfigPatch",
 		mgr.GetClient(),
 		patchHandlers...,
 	)
@@ -52,7 +52,7 @@ func MetaWorkerPatchHandler(mgr manager.Manager) handlers.Named {
 	patchHandlers = append(patchHandlers, genericmutation.WorkerMetaMutators()...)
 
 	return mutation.NewMetaGeneratePatchesHandler(
-		"awsWorkerv3ConfigPatch",
+		"awsWorkerV4ConfigPatch",
 		mgr.GetClient(),
 		patchHandlers...,
 	)