fix: uses consistent spelling (#1115)

**What problem does this PR solve?**:
Uses consistent spelling of the word "flavor"

**Which issue(s) this PR fixes**:
Fixes #

**How Has This Been Tested?**:
<!--
Please describe the tests that you ran to verify your changes.
Provide output from the tests and any manual steps needed to replicate
the tests.
-->

**Special notes for your reviewer**:
<!--
Use this to provide any additional information to the reviewers.
This may include:
- Best way to review the PR.
- Where the author wants the most review attention on.
- etc.
-->

Author: faiq

test/e2e/quick_start_test.go

@@ -54,13 +54,13 @@ var _ = Describe("Quick start", func() {
 							default:
 								Fail("unknown addon strategy: " + addonStrategy)
 							}
-							flavour := fmt.Sprintf(
+							flavor := fmt.Sprintf(
 								"topology-%s-%s",
 								strings.ToLower(cniProvider),
 								strategy,
 							)
 							Context(
-								flavour,
+								flavor,
 								func() {
 									var (
 										testE2EConfig                    *clusterctl.E2EConfig
@@ -159,7 +159,7 @@ var _ = Describe("Quick start", func() {
 											BootstrapClusterProxy:  bootstrapClusterProxy,
 											ArtifactFolder:         artifactFolder,
 											SkipCleanup:            skipCleanup,
-											Flavor:                 ptr.To(flavour),
+											Flavor:                 ptr.To(flavor),
 											InfrastructureProvider: ptr.To(lowercaseProvider),
 											PostMachinesProvisioned: func(proxy capiframework.ClusterProxy, namespace, clusterName string) {
 												capiframework.AssertOwnerReferences(
@@ -232,7 +232,7 @@ var _ = Describe("Quick start", func() {
 														),
 														Count: nodeCount,
 														WaitForNodesReady: testE2EConfig.GetIntervals(
-															flavour,
+															flavor,
 															"wait-nodes-ready",
 														),
 													},
@@ -258,23 +258,23 @@ var _ = Describe("Quick start", func() {
 														WorkloadCluster:        workloadCluster,
 														InfrastructureProvider: lowercaseProvider,
 														DeploymentIntervals: testE2EConfig.GetIntervals(
-															flavour,
+															flavor,
 															"wait-deployment",
 														),
 														DaemonSetIntervals: testE2EConfig.GetIntervals(
-															flavour,
+															flavor,
 															"wait-daemonset",
 														),
 														HelmReleaseIntervals: testE2EConfig.GetIntervals(
-															flavour,
+															flavor,
 															"wait-helmrelease",
 														),
 														ClusterResourceSetIntervals: testE2EConfig.GetIntervals(
-															flavour,
+															flavor,
 															"wait-clusterresourceset",
 														),
 														ResourceIntervals: testE2EConfig.GetIntervals(
-															flavour,
+															flavor,
 															"wait-resource",
 														),
 													},
@@ -286,7 +286,7 @@ var _ = Describe("Quick start", func() {
 														WorkloadCluster: workloadCluster,
 														ClusterProxy:    proxy,
 														DeploymentIntervals: testE2EConfig.GetIntervals(
-															flavour,
+															flavor,
 															"wait-deployment",
 														),
 													},
@@ -298,7 +298,7 @@ var _ = Describe("Quick start", func() {
 														WorkloadCluster: workloadCluster,
 														ClusterProxy:    proxy,
 														DeploymentIntervals: testE2EConfig.GetIntervals(
-															flavour,
+															flavor,
 															"wait-deployment",
 														),
 													},

test/e2e/self_hosted_test.go

@@ -47,13 +47,13 @@ var _ = Describe("Self-hosted", Serial, func() {
 							default:
 								Fail("unknown addon strategy: " + addonStrategy)
 							}
-							flavour := fmt.Sprintf(
+							flavor := fmt.Sprintf(
 								"topology-%s-%s",
 								strings.ToLower(cniProvider),
 								strategy,
 							)
 							Context(
-								flavour,
+								flavor,
 								func() {
 									framework.SelfHostedSpec(
 										ctx,
@@ -83,7 +83,7 @@ var _ = Describe("Self-hosted", Serial, func() {
 												BootstrapClusterProxy:  bootstrapClusterProxy,
 												ArtifactFolder:         artifactFolder,
 												SkipCleanup:            skipCleanup,
-												Flavor:                 flavour,
+												Flavor:                 flavor,
 												InfrastructureProvider: ptr.To(lowercaseProvider),
 												ClusterName: ptr.To(clusterNamePrefix +
 													util.RandomString(
@@ -120,23 +120,23 @@ var _ = Describe("Self-hosted", Serial, func() {
 															ClusterProxy:    proxy,
 															WorkloadCluster: workloadCluster,
 															DeploymentIntervals: e2eConfig.GetIntervals(
-																flavour,
+																flavor,
 																"wait-deployment",
 															),
 															DaemonSetIntervals: e2eConfig.GetIntervals(
-																flavour,
+																flavor,
 																"wait-daemonset",
 															),
 															HelmReleaseIntervals: e2eConfig.GetIntervals(
-																flavour,
+																flavor,
 																"wait-helmrelease",
 															),
 															ClusterResourceSetIntervals: e2eConfig.GetIntervals(
-																flavour,
+																flavor,
 																"wait-clusterresourceset",
 															),
 															ResourceIntervals: e2eConfig.GetIntervals(
-																flavour,
+																flavor,
 																"wait-resource",
 															),
 														},
@@ -148,7 +148,7 @@ var _ = Describe("Self-hosted", Serial, func() {
 															WorkloadCluster: workloadCluster,
 															ClusterProxy:    proxy,
 															DeploymentIntervals: e2eConfig.GetIntervals(
-																flavour,
+																flavor,
 																"wait-deployment",
 															),
 														},
@@ -159,7 +159,7 @@ var _ = Describe("Self-hosted", Serial, func() {
 															WorkloadCluster: workloadCluster,
 															ClusterProxy:    proxy,
 															DeploymentIntervals: e2eConfig.GetIntervals(
-																flavour,
+																flavor,
 																"wait-deployment",
 															),
 														},