Skip to content

Commit 1c2d65d

Browse files
authored
ci: Run e2e jobs only if unit-test, lint-*, and pre-commit jobs pass (#796)
**What problem does this PR solve?**: It's wasteful to run the e2e jobs before the other jobs pass, since making the other jobs pass almost certainly requires a change to the PR, which then requires the e2e jobs to run again, discarding the previous result. Before: ![image](https://github.com/nutanix-cloud-native/cluster-api-runtime-extensions-nutanix/assets/3445370/93928c9f-c6a4-4bbf-891e-e3554f4aca42) After: ![image](https://github.com/nutanix-cloud-native/cluster-api-runtime-extensions-nutanix/assets/3445370/17dfafad-e06a-4027-8a31-c0a99960ba22) **Which issue(s) this PR fixes**: Fixes # **How Has This Been Tested?**: <!-- Please describe the tests that you ran to verify your changes. Provide output from the tests and any manual steps needed to replicate the tests. --> **Special notes for your reviewer**: <!-- Use this to provide any additional information to the reviewers. This may include: - Best way to review the PR. - Where the author wants the most review attention on. - etc. -->
1 parent 62397e3 commit 1c2d65d

File tree

1 file changed

+12
-0
lines changed

1 file changed

+12
-0
lines changed

.github/workflows/checks.yml

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,12 @@ jobs:
5555
test-results: test.json
5656

5757
e2e-quick-start:
58+
needs:
59+
- "lint-gha"
60+
- "lint-go"
61+
- "lint-test-helm"
62+
- "pre-commit"
63+
- "unit-test"
5864
strategy:
5965
matrix:
6066
provider:
@@ -82,6 +88,12 @@ jobs:
8288
checks: write
8389

8490
e2e-self-hosted:
91+
needs:
92+
- "lint-gha"
93+
- "lint-go"
94+
- "lint-test-helm"
95+
- "pre-commit"
96+
- "unit-test"
8597
strategy:
8698
matrix:
8799
provider:

0 commit comments

Comments
 (0)