[18.0][MIG] product_unique_internal_reference: Migration to 18.0 #733
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR migrates the product_unique_internal_reference module from a previous version to Odoo 18.0. The module ensures unique internal references for products across companies and handles various scenarios including product templates, variants, and multi-company configurations.
Key Changes:
- Migration of all module files to version 18.0
- Updated manifest and version information
- Comprehensive test suite covering duplicate reference scenarios
- Multi-company aware validation logic
Reviewed Changes
Copilot reviewed 14 out of 15 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
__manifest__.py |
Updated version to 18.0.1.0.0 and module metadata |
models/product_template.py |
Added validation constraints for unique internal references in templates |
models/product_product.py |
Added validation constraints for unique internal references in product variants |
tests/test_product_unique_internal_reference.py |
Comprehensive test suite covering all duplicate reference scenarios |
hooks.py |
Pre-installation hook to check for existing conflicting references |
i18n/es.po |
Spanish translation file for error messages and UI text |
| Various documentation files | README, description, and contributor information |
| "Exception" | ||
| msgstr "" | ||
| "Las referencias internas no son iguales, esto no debería haber lanzado una " | ||
| "excepción" |
There was a problem hiding this comment.
The .po file is missing a blank line at the end of the file, which is required by coding guidelines.
deeniiz
force-pushed
the
18.0-mig-product_unique_internal_reference
branch
from
496cfcc to
77ff40c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.