MAINT: Refactor - parametrize test_reference

Refactors test_full.test_reference using the parametrization
facilities of pytest. In principle, improves readibility and
makes it easier to extend the test.

Author: rossbar

numpydoc/tests/test_full.py

@@ -77,25 +77,20 @@ def test_my_function(sphinx_app):
     assert 'glossary.html#term-iterable' in html
 
 
-def test_reference(sphinx_app):
+@pytest.mark.parametrize(("html_file", "expected_length"), (
+    (["index.html"], 1),
+    (["generated", "numpydoc_test_module.my_function.html"], 1),
+    (["generated", "numpydoc_test_module.MyClass.html"], 1),
+))
+def test_reference(sphinx_app, html_file, expected_length):
     """Test for bad references"""
     out_dir = sphinx_app.outdir
-    html_files = [
-        ["index.html"],
-        ["generated", "numpydoc_test_module.my_function.html"],
-        ["generated", "numpydoc_test_module.MyClass.html"],
-    ]
 
-    expected_lengths = [1, 1, 1]
-
-    for html_file, expected_length in zip(html_files, expected_lengths):
-        html_file = op.join(out_dir, *html_file)
-
-        with open(html_file, 'r') as fid:
-            html = fid.read()
+    with open(op.join(out_dir, *html_file), 'r') as fid:
+        html = fid.read()
 
-        reference_list = re.findall(r'<a class="fn-backref" href="\#id\d+">(.*)<\/a>', html)
+    reference_list = re.findall(r'<a class="fn-backref" href="\#id\d+">(.*)<\/a>', html)
 
-        assert len(reference_list) == expected_length
-        for ref in reference_list:
-            assert '-' not in ref  # Bad reference if it contains "-" e.g. R1896e33633d5-1
+    assert len(reference_list) == expected_length
+    for ref in reference_list:
+        assert '-' not in ref  # Bad reference if it contains "-" e.g. R1896e33633d5-1