MAINT: Fail if flake8 detects errors and fix existing errors

Author: Kai-Striega

.github/workflows/pythonpackage.yml

@@ -24,8 +24,8 @@ jobs:
       run: |
         # stop the build if there are Python syntax errors or undefined names
         poetry run flake8 . --count --select=E9,F63,F7,F82 --show-source --statistics
-        # exit-zero treats all errors as warnings. The GitHub editor is 127 chars wide
-        poetry run flake8 . --count --exit-zero --max-complexity=10 --max-line-length=127 --statistics
+        # The GitHub editor is 127 chars wide
+        poetry run flake8 . --ignore=F401,F403 --count --max-complexity=10 --max-line-length=127 --statistics
     - name: Test with pytest
       run: |
         poetry run pytest

numpy_financial/_financial.py

@@ -27,16 +27,14 @@
                 'start': 1,
                 'finish': 0}
 
-# Define custom Exceptions
 
 class NoRealSolutionException(Exception):
     """ No real solution to the problem. """
-
     pass
 
+
 class IterationsExceededException(Exception):
     """ Maximum number of iterations reached. """
-
     pass