Skip to content

Commit 8c50b7f

Browse files
authored
fix(core): only cleanup db connection on exit (#31137)
<!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> <!-- If this is a particularly complex change or feature addition, you can request a dedicated Nx release for this pull request branch. Mention someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they will confirm if the PR warrants its own release for testing purposes, and generate it for you if appropriate. --> ## Current Behavior <!-- This is the behavior we have today --> db connections are cleaned up on SIGTERM, SIGHUP, SIGINT, AND exit. On SIGTERM, SIGHUP, and SIGINT, the process exits there.. which short circuits other SIGTERM, SIGHUP, and SIGINT handlers. ## Expected Behavior <!-- This is the behavior we should expect with the changes in this PR --> db connections are only cleaned up when the process actually exits. It does not exit the process here in response to any signals. ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes #
1 parent f339a1a commit 8c50b7f

File tree

1 file changed

+1
-19
lines changed

1 file changed

+1
-19
lines changed

packages/nx/bin/nx.ts

Lines changed: 1 addition & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -283,26 +283,8 @@ const getLatestVersionOfNx = ((fn: () => string) => {
283283
return () => cache || (cache = fn());
284284
})(_getLatestVersionOfNx);
285285

286-
function nxCleanup(signal?: NodeJS.Signals) {
287-
removeDbConnections();
288-
if (signal) {
289-
process.exit(signalToCode(signal));
290-
} else {
291-
process.exit();
292-
}
293-
}
294-
295286
process.on('exit', () => {
296-
nxCleanup();
297-
});
298-
process.on('SIGINT', () => {
299-
nxCleanup('SIGINT');
300-
});
301-
process.on('SIGTERM', () => {
302-
nxCleanup('SIGTERM');
303-
});
304-
process.on('SIGHUP', () => {
305-
nxCleanup('SIGHUP');
287+
removeDbConnections();
306288
});
307289

308290
main();

0 commit comments

Comments
 (0)