Skip to content

Commit 02651bc

Browse files
committed
Upgrade tests to net8.0
1 parent cf87a64 commit 02651bc

File tree

3 files changed

+13
-10
lines changed

3 files changed

+13
-10
lines changed

.github/workflows/dotnet-test.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ jobs:
1616
- name: Setup .NET
1717
uses: actions/setup-dotnet@v2
1818
with:
19-
dotnet-version: 6.0.x
19+
dotnet-version: 8.0.x
2020
- name: Restore dependencies
2121
run: dotnet restore src
2222
- name: Build Lib
Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
<Project Sdk="Microsoft.NET.Sdk">
22

33
<PropertyGroup>
4-
<TargetFramework>net6.0</TargetFramework>
4+
<TargetFramework>net8.0</TargetFramework>
55
<IsPackable>false</IsPackable>
66
</PropertyGroup>
77

@@ -10,13 +10,11 @@
1010
</ItemGroup>
1111

1212
<ItemGroup>
13-
<PackageReference Include="System.ValueTuple" Version="4.4.0" />
1413
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.8.0" />
1514
<PackageReference Include="xunit.runner.visualstudio" Version="2.5.3" />
1615
<PackageReference Include="xunit" Version="2.6.1" />
1716
<PackageReference Include="System.Data.SqlClient" Version="4.8.6" />
18-
<PackageReference Include="Microsoft.Data.Sqlite" Version="6.0.25" />
19-
<PackageReference Include="System.ComponentModel.Annotations" Version="4.4.0" />
17+
<PackageReference Include="Microsoft.Data.Sqlite" Version="8.0.*" />
2018
</ItemGroup>
2119

2220
</Project>

src/NReco.Data.Tests/RelexTests.cs

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -85,8 +85,12 @@ public class RelexTests
8585
@"SELECT u.[User ID] FROM [company users] u",
8686
@"SELECT name FROM users WHERE ((id<>@p0) And (id<>@p1)) Or (NOT(id=@p2))",
8787
@"SELECT name FROM users WHERE (NOT(id=@p0)) And (id<>@p1)",
88-
};
89-
88+
};
89+
90+
string[] relExInvalidSyntaxSamples = new string[] {
91+
"users[id"
92+
};
93+
9094
[Fact]
9195
public void test_Parse() {
9296
var relExParser = new RelexParser();
@@ -128,9 +132,10 @@ public void test_Parse() {
128132
Assert.Equal(1, complexQ.Fields.Length);
129133
Assert.Equal(3, complexQ.Sort.Length);
130134

131-
Assert.Throws<RelexParseException>(() => {
132-
relExParser.Parse("users[id");
133-
});
135+
foreach (var invalidRelex in relExInvalidSyntaxSamples)
136+
Assert.Throws<RelexParseException>(() => {
137+
relExParser.Parse(invalidRelex);
138+
});
134139
}
135140

136141
[Fact]

0 commit comments

Comments
 (0)