Skip to content

Commit 21e36bb

Browse files
authored
Remove role="main" to ensure 'NPM Docs' page contains only one main landmark (#1354)
<!-- What / Why --> This pull request removes the `role="main"` attribute from the `PageElement` component in the `src/page.js` file to ensure there is only one main landmark on the 'NPM Docs' page. ## Before <img width="1725" alt="NPM Docs page with more than one main landmark" src="https://github.com/user-attachments/assets/dd397661-24a0-489b-813e-638e028c6242"> ## After <img width="1711" alt="NPM Docs page with only one main landmark" src="https://github.com/user-attachments/assets/86d300a1-d11c-4f0d-80e1-781566b5c106"> ## References - github/accessibility-audits#9212
1 parent 293ef85 commit 21e36bb

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/page.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ const PageElement = ({element, props}) => {
3535
<PageProvider value={page}>
3636
<Box sx={{display: 'flex', flexDirection: 'column', minHeight: '100vh'}}>
3737
<Header />
38-
<Box sx={{zIndex: 0, display: 'flex', flex: '1 1 auto', flexDirection: 'row'}} role="main">
38+
<Box sx={{zIndex: 0, display: 'flex', flex: '1 1 auto', flexDirection: 'row'}}>
3939
<Box sx={{display: ['none', null, null, 'block']}}>
4040
<Sidebar />
4141
</Box>

0 commit comments

Comments
 (0)