-
Notifications
You must be signed in to change notification settings - Fork 4.2k
Description
📜 Description
With the Self-Hosted Novu, we want to use the S3 storage but not with an access key id and a secret access key since it's considered a bad practice.
Instead we want to use an IRSA (https://docs.aws.amazon.com/eks/latest/userguide/iam-roles-for-service-accounts.html) inside an EKS cluster. It will automatically generate credentials inside the pod with the right env variables but it's not using AWS_ACCESS_KEY_ID
and AWS_SECRET_ACCESS_KEY
and those are required by Novu.
👟 Reproduction steps
Inside an EKS cluster, with an IRSA configured, we cannot upload a brand image for example.
Helm deployment with service account with the IRSA (https://github.com/novuhq/community-k8s/tree/main/helm):
👍 Expected behavior
An S3 upload should work with an IRSA role
👎 Actual Behavior with Screenshots
Even with empty string variable for access key and secret, we have a error when uploading the brand logo for example
Novu version
Novu Self-Hosted 0.24.7
npm version
10.8.2
node version
20.19.0
📃 Provide any additional context for the Bug.
No response
👀 Have you spent some time to check if this bug has been raised before?
- I checked and didn't find a similar issue
🏢 Have you read the Contributing Guidelines?
- I have read the Contributing Guidelines
Are you willing to submit PR?
Yes I am willing to submit a PR!