Skip to content

✨ Polishing: avoid react and react dom as dependencies for notification-center-vue #5214

@foxted

Description

@foxted

πŸ“œ Description

When pulling notification-center-vue in a Vue/Nuxt project, the react and react-dom dependencies should be "devDependencies". notification-center seems to only have react and react-dom as devDependencies as well.

This also conflicts with other potential third-party packages that have react as a peer dependency (like @vercel/analytics, forcing the use of --legacy-peer-deps flag or the overrides property in package.json.

πŸ‘Ÿ Reproduction steps

  • Install notification-center-vue in any vue project with @vercel/analytics
  • Notice the mismatch in version

πŸ‘ Expected behavior

It should not have react and react-dom listed as dependencies, but maybe devDependencies or peerDepencencies instead.

πŸ“ƒ Provide any additional context for the Bug.

No response

πŸ‘€ Have you spent some time to check if this bug has been raised before?

  • I checked and didn't find similar issue

🏒 Have you read the Contributing Guidelines?

Metadata

Metadata

Assignees

No one assigned

    Labels

    InboxbugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions