/v1/messages with Query Parameters not working for me.

[KhushbuAsrani08]

Hi everyone,

get messages api with query parameter gives the whole bunch of subscribers transactions not a filtered records.
It should give the filtered data as per the passed query parameters.
Below is the steps to generate issue.Please let me know if I am missing anything.

const transactionIds = [***,]
const response = await fetch(
${ isNil(configuration) ? "" : configuration.api_url }/v1/messages?subscriberId="****************************"&transactionId=${transactionIds},
{
method: "GET",
headers: {
"Content-Type": "application/json",
Authorization: ApiKey ${isNil(configuration) ? "" : configuration.api_key},
},
}
)

This is the way I am using api end point.

1. It should give the filtered data
   2.If I am using only filter of transaction id then also it should gives the only queried transaction id of data.

Thanks in advance

[michaldziuba03]

Hello @KhushbuAsrani08

Do you send transactionId as ?transactionId=1,2,3,4,5, right?

After fast source code check, I suspect that API understands your query just as a string "1,2,3,4,5", not array.

I think you should pass array of transactions as following:
?transactionId=1&transactionId=2&transactionId=3

You can try something like this in your code to get query params for all your transactions (untested):

const transactionIds = ['111', '222', '333']

transactionIds.map(val => `transactionId=${val}`).join('&');
// 'transactionId=111&transactionId=222&transactionId=333'

[KhushbuAsrani08]

@michaldziuba03 Thank for the response.
I have tried this way before http://localhost:3000/v1/messages?transactionId=*******************************
It was giving me response like this

haders {}
ok: true
redirected: false
status: 200
type: "cors"
url
:
"http://localhost:3000/v1/messages?transactionId=**************************************"

Am I missing anything here?

[michaldziuba03]

@KhushbuAsrani08

Here is my request:

Everything works fine. I tried to simulate your case:

async function main() {
  const options = {
    method: 'GET',
    headers: {Authorization: 'ApiKey <NOVU_API_KEY>'}
  };
  
  const transactionIds = [
    '000049c7-1b6c-463f-0000-000000000000',
    '00000aa11-763b-43e3-000-000000000000',
  ]
  
  const subscriberId = '600000000000000000000000';
  
  const url = new URL('https://api.novu.co/v1/messages');
  
  transactionIds.forEach(val => url.searchParams.append('transactionId', val));
  url.searchParams.set('subscriberId', subscriberId);

  const result = await fetch(url.toString(), options);
  const json = await result.json();

  console.log(json);
}

main();

[michaldziuba03]

@KhushbuAsrani08

@michaldziuba03 Thank for the response. I have tried this way before http://localhost:3000/v1/messages?transactionId=******************************* It was giving me response like this

haders {} ok: true redirected: false status: 200 type: "cors" url : "http://localhost:3000/v1/messages?transactionId=**************************************"

Am I missing anything here?

You got HTTP response with status 200, so what is wrong? Just read result.json() value to get messages.

[KhushbuAsrani08]

@michaldziuba03 , I tried the above code. Its giving count of data less as compare to previously but its giving irrelevant data.
Data is not matching as the filters we are passing.

[KhushbuAsrani08]

@michaldziuba03 , any suggestion on this?
your response will be appreciated as i have to fix this in my code asap.

[michaldziuba03]

@KhushbuAsrani08 Do you run Novu locally, right? I cannot reproduce your issues (I use cloud Novu). If you run locally, what version you currently use? (0.16.x is newest)

If you run Novu locally, can you try if on cloud version you encounter same problems?

I think some older versions of Novu may have issues with result relevance.

[KhushbuAsrani08]

@michaldziuba03, yes I am using latest version of novu.
const options = {
method: "GET",
headers: {
"Content-Type": "application/json",
Authorization: ApiKey ${isNil(configuration) ? "" : configuration.api_key},
},
}

const transactionIds = ["31c9f316-0ff7-422b-96b2-a45ef4dc0729"]

const subscriberId = "6419952559c98f7cf269c5b5"

const url = new URL(`${isNil(configuration) ? "" : configuration.api_url}/v1/messages`)

transactionIds.forEach((val) => url.searchParams.append("transactionId", val))
url.searchParams.set("subscriberId", subscriberId)

const result = await fetch(url.toString(), options)
const json = await result.json()

console.log(json)

**Please see the above code.I should get only one record as per the above code but I am getting irrelevant data as well.**

**Below is the response of above code :** 

[michaldziuba03]

@jainpawan21 can you help us?

[jainpawan21]

@KhushbuAsrani08
Are you sending transactionId field in POST /events/triggerapi ?
I feel you are sending same transactionId with each trigger.

I just tried, but I am not able to reproduce it.

[KhushbuAsrani08]

@jainpawan21 , let me give you brief explanation.
I have a send one message to 10 subscribers with 'Accept' and 'Decline' button (Method novu.trigger()). Each sent message output is transaction Id.
I am saving those transaction Ids.
If one of subscriber click on Accept button then status changed internally Accepted as per transaction Id. Therefore message sent to other 9 subscriber of status should also get change as Accepted.
I am looking for an API which gives me messages as per transactionIds.
Using API

but getting irrelevant data. As you can see I have send only one transaction Id and one subscriber Id in above api call but it gives me result as follow which is not correct.
Expected - I should get only single record as I have send single TransactionId

Thank you

[ainouzgali]

'I have a send one message to 10 subscribers with 'Accept' and 'Decline' button (Method novu.trigger()). Each sent message output is transaction Id.'
Are you sending to all those 10 subscribers in one novu.trigger?

[KhushbuAsrani08]

Hi @jainpawan21 ,

any suggestion on this?

Thank you

[ainouzgali]

Can you please share the code snippet of how you trigger? Its a bit unclear to me what you are doing with the transactionIds .

My confusion comes from this
'If one of subscriber click on Accept button then status changed internally Accepted as per transaction Id. Therefore message sent to other 9 subscriber of status should also get change as Accepted.'

[KhushbuAsrani08]

@ainouzgali
see I am sending one message to two diff subscribers
Subscriber 1 :

Subscriber 2 :

Now I have clicked on Accept button of subscriber 1 message then it will look like this to respective suscribers
subscriber1

Subscriber 2

Here code I have used :
await updateAction({
messageId: message._id,
actionButtonType:
type.target.innerText === "Decline" ? ButtonTypeEnum.PRIMARY : ButtonTypeEnum.SECONDARY,
status: MessageActionStatusEnum.DONE,
payload: { status: type.target.innerText === "Decline" ? "Declined" : "Accepted" },
})

What I am expecting here when I click on Accept button of subscriber 1 then same changes should be on subscriber2 screen because both messages are similar.

To get the details of both messages I am using above mentioned api but I am not getting relevant data.
If I am sending only one transactionId to api then should only give me record 1.But its giving data of diff 100s transaction Ids as well.

[KhushbuAsrani08]

No one by one. Bcz I have different payload for each subscriber. Corresponding to each trigger I am getting transactionId which I am saving for future use. Get Outlook for Android<https://aka.ms/AAb9ysg>

…

________________________________ From: ainouzgali ***@***.***> Sent: Monday, July 17, 2023 5:23:43 PM To: novuhq/novu ***@***.***> Cc: Khushbu Asrani ***@***.***>; Mention ***@***.***> Subject: Re: [novuhq/novu] /v1/messages with Query Parameters not working for me. (Discussion #3755) Are you sending to all those 10 subscribers in one novu.trigger? — Reply to this email directly, view it on GitHub<#3755 (reply in thread)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/A54A2O574TGFPVK3B4IFFW3XQURUPANCNFSM6AAAAAA2ELRJOQ>. You are receiving this because you were mentioned.Message ID: ***@***.***>

[ainouzgali]

@KhushbuAsrani08 are you on discord? We could schedule a call, because I feel I need to see some code snippets in order to help

[KhushbuAsrani08]

yes, I have registered just now.

[ainouzgali]

https://discord.gg/novu

I am galiainouz on discord

[ainouzgali]

Update - filtering messages by transactionId has been added as of v0.16.3. In this question an older version has been used.
@KhushbuAsrani08 thanks for reaching out! I will close this for now, if you still have a problem after you upgrade, let us know.