Skip to content

Commit e5eff66

Browse files
committed
cache only when kid is found, even unless auto_detect mode. and pass options to delete
1 parent 3acd910 commit e5eff66

File tree

2 files changed

+3
-7
lines changed

2 files changed

+3
-7
lines changed

lib/json/jwk/set/fetcher.rb

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -72,14 +72,10 @@ def self.fetch(jwks_uri, kid:, auto_detect: true, **options)
7272
end
7373
)
7474
)
75+
cache.delete(cache_key, options) if jwks[kid].blank?
7576

7677
if auto_detect
77-
if jwks[kid]
78-
jwks[kid]
79-
else
80-
cache.delete(cache_key)
81-
raise KidNotFound
82-
end
78+
jwks[kid] or raise KidNotFound
8379
else
8480
jwks
8581
end

spec/json/jwk/set/fetcher_spec.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,7 @@ def delete(cache_key)
122122
end
123123

124124
it do
125-
expect(JSON::JWK::Set::Fetcher.cache).to receive(:delete).with(cache_key)
125+
expect(JSON::JWK::Set::Fetcher.cache).to receive(:delete).with(cache_key, {})
126126
expect do
127127
mock_json :get, jwks_uri, 'jwks' do
128128
subject

0 commit comments

Comments
 (0)