Skip to content

Containerized | Versioning | Return 405 for Get/Head Specific Delete-Marker #8369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
shirady opened this issue Sep 16, 2024 · 4 comments · May be fixed by #8733
Open

Containerized | Versioning | Return 405 for Get/Head Specific Delete-Marker #8369

shirady opened this issue Sep 16, 2024 · 4 comments · May be fixed by #8733
Assignees
@vh05

Comments

@shirady
Copy link
Contributor

shirady commented Sep 16, 2024

Environment info

  • NooBaa Version: master 5.18
  • Platform: Containerized

Background

In PR #8338 added a fix in NSFS.
Since I added the mapping between RPC error and S3 error: METHOD_NOT_ALLOWED: S3Error.MethodNotAllowed it might be that we probably have this issue in containerized.

Actual behavior

  1. If the specified version in the request is a delete marker the returned is 404 Not Found.

Expected behavior

  1. If the specified version in the request is a delete marker the returned is 405 Method Not Allowed.

Steps to reproduce

  1. Create a data bucket with versioning Enabled.
  2. Put an object and then delete an object (save the version-id).
  3. Try to head/get with the key by the version-id.

More information - Screenshots / Logs / Other output

  1. According to the AWS docs GetObject and HeadObject:
    If the specified version in the request is a delete marker, the response returns a 405 Method Not Allowed error and the Last-Modified: timestamp response header.
@shirady shirady mentioned this issue Sep 16, 2024
Merged
2 tasks
@github-actions GitHub Actions
Copy link

This issue had no activity for too long - it will now be labeled stale. Update it to prevent it from getting closed.

@github-actions github-actions bot added the Stale label Dec 16, 2024
@github-actions GitHub Actions
Copy link

This issue is stale and had no activity for too long - it will now be closed.

@shirady shirady reopened this Jan 16, 2025
@shirady shirady removed the Stale label Jan 16, 2025
@shirady
Copy link
Contributor Author

shirady commented Jan 28, 2025

The tests in PR #8338 did not contain header checks that were added in PR #8402

vh05 added a commit to vh05/noobaa-core that referenced this issue Jan 29, 2025
@vh05
Return 405 for Get/Head Specific Delete-Marker
ecae927 
If the specified version in the request is a delete marker
the returned is 405 Method Not Allowed.

Fixes: noobaa#8369

Signed-off-by: Vinayakswami Hariharmath <vharihar@redhat.com>
@vh05 vh05 linked a pull request Jan 29, 2025 that will close this issue
Open
vh05 added a commit to vh05/noobaa-core that referenced this issue Jan 29, 2025
@vh05
Return 405 for Get/Head Specific Delete-Marker
146791b 
If the specified version in the request is a delete marker
the returned is 405 Method Not Allowed.

Fixes: noobaa#8369

Signed-off-by: Vinayakswami Hariharmath <vharihar@redhat.com>
vh05 added a commit to vh05/noobaa-core that referenced this issue Feb 4, 2025
@vh05
Return 405 for Get/Head Specific Delete-Marker
240fab2 
If the specified version in the request is a delete marker
the returned is 405 Method Not Allowed.

Fixes: noobaa#8369

Signed-off-by: Vinayakswami Hariharmath <vharihar@redhat.com>
@github-actions GitHub Actions
Copy link

This issue had no activity for too long - it will now be labeled stale. Update it to prevent it from getting closed.

@github-actions github-actions bot added the Stale label Apr 28, 2025
@shirady shirady removed the Stale label Apr 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vh05 vh05

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Return 405 for Get/Head Specific Delete-Marker vh05/noobaa-core
2 participants
@shirady @vh05