Skip to content

Commit b84ca35

Browse files
authored
Merge pull request #8910 from romayalon/romy-fix-connection-health
NC | Health | Connection test is invalid because of additional .json
2 parents 185ab19 + c7c3eb1 commit b84ca35

File tree

2 files changed

+14
-2
lines changed

2 files changed

+14
-2
lines changed

docs/bucket-notifications.md

Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ A notification json has these fields:
1010
If not specified, the notification is relevant for all events.
1111
- TopicArn: The connection file (see below). (To specify a Kafka target topic, see "Kafka Connection Fields" below).
1212

13-
Example for a bucket's notification configuration, in a file:
13+
Example for a bucket's notification configuration on containerized environment, in a file:
1414
{
1515
"TopicConfigurations": [
1616
{
@@ -23,6 +23,18 @@ Example for a bucket's notification configuration, in a file:
2323
]
2424
}
2525

26+
Example for a bucket's notification configuration on Non-containerized environment, in a file:
27+
{
28+
"TopicConfigurations": [
29+
{
30+
"Id": "created_from_s3op",
31+
"TopicArn": "secret-name/connect",
32+
"Events": [
33+
"s3:ObjectCreated:*"
34+
]
35+
}
36+
]
37+
}
2638

2739
## Connection File
2840
A connection file contains some fields that specify the target notification server.

src/manage_nsfs/health.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -418,7 +418,7 @@ class NSFSHealth {
418418
const connection_file_path = this.config_fs.get_connection_path_by_name(config_file_name);
419419
const test_notif_err = await notifications_util.test_notifications([{
420420
name: config_data.name,
421-
topic: [this.config_fs.json(config_file_name)]
421+
topic: [config_file_name]
422422
}], this.config_fs.config_root);
423423
if (test_notif_err) {
424424
res = get_invalid_object(config_data.name, connection_file_path, undefined, test_notif_err.code);

0 commit comments

Comments
 (0)