Merge pull request #8484 from tangledbytes/utkarsh/feat/limit-key-length

Author: guymguym

config.js

@@ -198,6 +198,22 @@ config.S3_RESTORE_REQUEST_MAX_DAYS = 30;
  */
 config.S3_RESTORE_REQUEST_MAX_DAYS_BEHAVIOUR = 'TRUNCATE';
 
+/**
+ * S3_MAX_KEY_LENGTH controls the maximum key length that will be accepted
+ * by NooBaa endpoints.
+ * 
+ * This value is 1024 bytes for S3 but the default is `Infinity`
+ */
+config.S3_MAX_KEY_LENGTH = Infinity;
+
+/**
+ * S3_MAX_BUCKET_NAME_LENGTH controls the maximum bucket name length that
+ * will be accepted by NooBaa endpoints.
+ * 
+ * This value is 63 bytes for S3 but the default is `Infinity`
+ */
+config.S3_MAX_BUCKET_NAME_LENGTH = Infinity;
+
 /////////////////////
 // SECRETS CONFIG  //
 /////////////////////

src/endpoint/s3/s3_errors.js

@@ -249,8 +249,8 @@ S3Error.InvalidURI = Object.freeze({
     message: 'Couldn\'t parse the specified URI.',
     http_code: 400,
 });
-S3Error.KeyTooLong = Object.freeze({
-    code: 'KeyTooLong',
+S3Error.KeyTooLongError = Object.freeze({
+    code: 'KeyTooLongError',
     message: 'Your key is too long.',
     http_code: 400,
 });

src/endpoint/s3/s3_rest.js

@@ -362,6 +362,14 @@ function get_bucket_and_key(req) {
             key = suffix;
         }
     }
+
+    if (key?.length > config.S3_MAX_KEY_LENGTH) {
+        throw new S3Error(S3Error.KeyTooLongError);
+    }
+    if (bucket?.length > config.S3_MAX_BUCKET_NAME_LENGTH) {
+        throw new S3Error(S3Error.InvalidBucketName);
+    }
+
     return {
         bucket,
         // decode and replace hadoop _$folder$ in key