bucket notification - prevent undefined read on timeout (#8996)

alphaprinz · web-flow · commit 947eb7fb94e5 · 2025-04-29T07:51:04.000-07:00
Signed-off-by: Amit Prinz Setter &lt;alphaprinz@gmail.com&gt;
diff --git a/src/util/notifications_util.js b/src/util/notifications_util.js
@@ -161,7 +161,7 @@ class Notificator {
 
     async handle_failed_notification(notif, failure_append, err) {
         if (this.nc_config_fs) {
-            new NoobaaEvent(NoobaaEvent.NOTIFICATION_FAILED).create_event(notif?.meta?.name, err, err.toString());
+            new NoobaaEvent(NoobaaEvent.NOTIFICATION_FAILED).create_event(notif?.meta?.name, err, err?.toString());
         }
 
         if (notif) {

Original file line number	Diff line number	Diff line change
`@@ -161,7 +161,7 @@ class Notificator {`
`161`	`161`
`162`	`162`	`async handle_failed_notification(notif, failure_append, err) {`
`163`	`163`	`if (this.nc_config_fs) {`
`164`		`- new NoobaaEvent(NoobaaEvent.NOTIFICATION_FAILED).create_event(notif?.meta?.name, err, err.toString());`
	`164`	`+ new NoobaaEvent(NoobaaEvent.NOTIFICATION_FAILED).create_event(notif?.meta?.name, err, err?.toString());`
`165`	`165`	`}`
`166`	`166`
`167`	`167`	`if (notif) {`