NC | lifecycle | add noncurrent days rule

Signed-off-by: nadav mizrahi <nadav.mizrahi16@gmail.com>

Author: nadavMiz

src/manage_nsfs/nc_lifecycle.js

@@ -588,7 +588,7 @@ class NCLifecycle {
 
     /**
      * check if object is delete candidate based on newer noncurrent versions rule
-     * @param {Object} object_info
+     * @param {nb.ObjectInfo} object_info
      * @param {Object} newer_noncurrent_state
      * @param {Number} num_newer_versions
      * @returns
@@ -608,21 +608,22 @@ class NCLifecycle {
 
     /**
      * check if object is delete candidate based on number of noncurrent days rule
-     * @param {Object} object_info
+     * @param {nb.ObjectInfo} object_info
      * @param {Number} num_non_current_days
      * @returns
      */
     filter_noncurrent_days(object_info, num_non_current_days) {
-        //TODO implement
-        return true;
+        if (object_info.is_latest) return false;
+        const noncurrent_time = object_info.nc_noncurrent_time;
+        return lifecycle_utils.get_file_age_days(noncurrent_time) >= num_non_current_days;
     }
 
     /**
      * get_candidates_by_noncurrent_version_expiration_rule processes the noncurrent version expiration rule
      * TODO:
      * POSIX - need to support both noncurrent_days and newer_noncurrent_versions
      * GPFS - implement noncurrent_days using GPFS ILM policy as an optimization
-     * @param {*} lifecycle_rule
+     * @param {Object} lifecycle_rule
      * @param {Object} bucket_json
      * @returns {Promise<Object[]>}
      */

src/sdk/namespace_fs.js

@@ -2634,6 +2634,8 @@ class NamespaceFS {
         const storage_class = Glacier.storage_class_from_xattr(stat.xattr);
         const size = Number(stat.xattr?.[XATTR_DIR_CONTENT] || stat.size);
         const tag_count = stat.xattr ? this._number_of_tags_fs_xttr(stat.xattr) : 0;
+        const nc_noncurrent_time = (stat.xattr?.[XATTR_NON_CURRENT_TIMESTASMP] && Number(stat.xattr[XATTR_NON_CURRENT_TIMESTASMP])) ||
+            stat.ctime.getTime();
 
         return {
             obj_id: etag,
@@ -2652,6 +2654,7 @@ class NamespaceFS {
             xattr: to_xattr(stat.xattr),
             tag_count,
             tagging: get_tags_from_xattr(stat.xattr),
+            nc_noncurrent_time,
 
             // temp:
             lock_settings: undefined,

src/sdk/nb.d.ts

@@ -442,6 +442,7 @@ interface ObjectInfo {
     restore_status?: RestoreStatus;
     checksum?: Checksum;
     object_parts?: GetObjectAttributesParts;
+    nc_noncurrent_time ?: number;
 }