Skip to content

Commit 4f128c0

Browse files
committed
change log printing in namespace_monitor
1. Add the bucket name in case of an error in S3, Azure, and GCP. 2. Change the printing of "has error as expected" to "has an unexpected error". Signed-off-by: shirady <57721533+shirady@users.noreply.github.com>
1 parent 90d5636 commit 4f128c0

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

src/server/bg_services/namespace_monitor.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ class NamespaceMonitor {
7676
this.update_last_monitoring(nsr._id, nsr.name, endpoint_type);
7777
} catch (err) {
7878
this.run_update_issues_report(err, nsr);
79-
dbg.log1(`test_namespace_resource_validity: namespace resource ${nsr.name} has error as expected`);
79+
dbg.log1(`test_namespace_resource_validity: namespace resource ${nsr.name} has an unexpected error`);
8080
}
8181
});
8282
dbg.log1(`test_namespace_resource_validity finished successfully..`);
@@ -146,7 +146,7 @@ class NamespaceMonitor {
146146
if (err.code === 'AccessDenied' && nsr.is_readonly_namespace()) {
147147
return;
148148
}
149-
dbg.log1('test_s3_resource: got error:', err);
149+
dbg.log1(`test_s3_resource: on bucket ${target_bucket} got error:`, err);
150150
if (err.code !== 'NoSuchKey') throw err;
151151
}
152152

@@ -174,7 +174,7 @@ class NamespaceMonitor {
174174
if (err.code === 'InsufficientAccountPermissions' && nsr.is_readonly_namespace()) {
175175
return;
176176
}
177-
dbg.log1('test_blob_resource: got error:', err);
177+
dbg.log1(`test_blob_resource: on bucket ${target_bucket} got error:`, err);
178178
if (err.code !== 'BlobNotFound') throw err;
179179
}
180180
}
@@ -200,7 +200,7 @@ class NamespaceMonitor {
200200
if (err.errors[0].reason === 'UserProjectAccessDenied' && nsr.is_readonly_namespace()) {
201201
return;
202202
}
203-
dbg.log1('test_gcs_resource: got error:', err);
203+
dbg.log1(`test_gcs_resource: on bucket ${target_bucket} got error:`, err);
204204
// https://cloud.google.com/storage/docs/json_api/v1/status-codes
205205
if (err.errors[0].reason !== 'notFound') throw err;
206206
}

0 commit comments

Comments
 (0)