Skip to content

Commit 1e0964c

Browse files
committed
Tests fix
Signed-off-by: Aayush Chouhan <achouhan@redhat.com>
1 parent 7eebc11 commit 1e0964c

File tree

2 files changed

+6
-5
lines changed

2 files changed

+6
-5
lines changed

src/endpoint/s3/s3_rest.js

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -116,10 +116,13 @@ async function handle_request(req, res) {
116116
}
117117

118118
const op_name = parse_op_name(req);
119-
const cors = req.params.bucket && await req.object_sdk.read_bucket_sdk_cors_info(req.params.bucket);
120119

120+
const cors = req.params.bucket && await req.object_sdk.read_bucket_sdk_cors_info(req.params.bucket);
121121
http_utils.set_cors_headers_s3(req, res, cors);
122122

123+
const rules = req.params.bucket && await req.object_sdk.read_bucket_lifecycle_config_info(req.params.bucket);
124+
http_utils.set_expiration_header(req, res, rules);
125+
123126
if (req.method === 'OPTIONS') {
124127
dbg.log1('s3_rest: handle_request : S3 request method is ', req.method);
125128
const error_code = req.headers.origin && req.headers['access-control-request-method'] ? 403 : 400;
@@ -139,8 +142,6 @@ async function handle_request(req, res) {
139142
authenticate_request(req);
140143
await authorize_request(req);
141144

142-
await http_utils.set_expiration_header(req, res);
143-
144145
dbg.log1('S3 REQUEST', req.method, req.originalUrl, 'op', op_name, 'request_id', req.request_id, req.headers);
145146
usage_report.s3_usage_info.total_calls += 1;
146147
usage_report.s3_usage_info[op_name] = (usage_report.s3_usage_info[op_name] || 0) + 1;

src/util/http_utils.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -672,10 +672,10 @@ const s3_error_options = {
672672
/**
673673
* @param {Object} req
674674
* @param {http.ServerResponse} res
675+
* @param {Object} rules
675676
*/
676-
async function set_expiration_header(req, res) {
677+
async function set_expiration_header(req, res, rules) {
677678
if (req.method === 'HEAD' || req.method === 'GET' || req.method === 'PUT') {
678-
const rules = req.params.bucket && await req.object_sdk.read_bucket_lifecycle_config_info(req.params.bucket);
679679
const object_md = {
680680
bucket: req.params.bucket,
681681
key: req.params.key,

0 commit comments

Comments
 (0)