From e8072a43bda3e1adb228c9f39a3a16014c206c5c Mon Sep 17 00:00:00 2001
From: Alexander Reynolds <alex@theory.shop>
Date: Mon, 16 Sep 2024 17:46:09 -0700
Subject: [PATCH 1/2] add e2e tests for adding to dataset

---
 tests/e2e/conftest.py | 17 +++++++++++++++++
 tests/e2e/test_sdk.py | 21 +++++++++++++++++++++
 2 files changed, 38 insertions(+)

diff --git a/tests/e2e/conftest.py b/tests/e2e/conftest.py
index 386d08c5..d2cf08f8 100644
--- a/tests/e2e/conftest.py
+++ b/tests/e2e/conftest.py
@@ -44,3 +44,20 @@ def csv_data():
 2024-09-05T18:08:00Z,28,42
 2024-09-05T18:09:00Z,29,41
 """
+
+
+@pytest.fixture(scope="session")
+def csv_data2():
+    return b"""\
+timestamp,temperature,humidity
+2024-09-05T18:10:00Z,30,40
+2024-09-05T18:11:00Z,31,39
+2024-09-05T18:12:00Z,32,38
+2024-09-05T18:13:00Z,33,37
+2024-09-05T18:14:00Z,34,36
+2024-09-05T18:15:00Z,35,35
+2024-09-05T18:16:00Z,36,34
+2024-09-05T18:17:00Z,37,33
+2024-09-05T18:18:00Z,38,32
+2024-09-05T18:19:00Z,39,31
+"""
diff --git a/tests/e2e/test_sdk.py b/tests/e2e/test_sdk.py
index b688d5c6..b607a9be 100644
--- a/tests/e2e/test_sdk.py
+++ b/tests/e2e/test_sdk.py
@@ -1,3 +1,4 @@
+from datetime import timedelta
 from unittest import mock
 from uuid import uuid4
 
@@ -63,6 +64,26 @@ def test_add_dataset_to_run_and_list_datasets(csv_data):
     assert ds2.rid == ds.rid
 
 
+def test_add_csv_to_dataset(csv_data, csv_data2):
+    name = f"dataset-{uuid4()}"
+    desc = f"TESTING sdk to add more data to a dataset {uuid4()}"
+
+    with mock.patch("builtins.open", mock.mock_open(read_data=csv_data)):
+        ds = nm.upload_csv("fake_path.csv", name, "timestamp", "iso_8601", desc)
+    ds.poll_until_ingestion_completed(interval=timedelta(seconds=0.1))
+
+    with mock.patch("builtins.open", mock.mock_open(read_data=csv_data2)):
+        ds = nm.upload_csv("fake_path.csv", name, "timestamp", "iso_8601", desc)
+        ds.add_csv_to_dataset("fake_path.csv", "timestamp", "iso_8601")
+    ds.poll_until_ingestion_completed(interval=timedelta(seconds=0.1))
+
+    assert ds.rid != ""
+    assert ds.name == name
+    assert ds.description == desc
+    assert len(ds.properties) == 0
+    assert len(ds.labels) == 0
+
+
 def test_update_attachment(csv_data):
     at_name = f"attachment-{uuid4()}"
     at_desc = f"sdk to add a attachment to a run {uuid4()}"

From 31e403fd876baf24bb1e5a9740d2b3660f1da7e5 Mon Sep 17 00:00:00 2001
From: Alexander Reynolds <alex@theory.shop>
Date: Mon, 16 Sep 2024 17:48:51 -0700
Subject: [PATCH 2/2] accidentally uploaded the csv twice

---
 tests/e2e/test_sdk.py | 1 -
 1 file changed, 1 deletion(-)

diff --git a/tests/e2e/test_sdk.py b/tests/e2e/test_sdk.py
index b607a9be..182df645 100644
--- a/tests/e2e/test_sdk.py
+++ b/tests/e2e/test_sdk.py
@@ -73,7 +73,6 @@ def test_add_csv_to_dataset(csv_data, csv_data2):
     ds.poll_until_ingestion_completed(interval=timedelta(seconds=0.1))
 
     with mock.patch("builtins.open", mock.mock_open(read_data=csv_data2)):
-        ds = nm.upload_csv("fake_path.csv", name, "timestamp", "iso_8601", desc)
         ds.add_csv_to_dataset("fake_path.csv", "timestamp", "iso_8601")
     ds.poll_until_ingestion_completed(interval=timedelta(seconds=0.1))