perf: use collectASequenceOfCodePointsFast

Author: KhafraDev

lib/fetch/dataURL.js

@@ -168,9 +168,11 @@ function collectASequenceOfCodePoints (condition, input, position) {
 
 /**
  * A faster collectASequenceOfCodePoints that only works when comparing a single character.
+ * @template {string|Buffer} T
  * @param {string} char
- * @param {string} input
+ * @param {T} input
  * @param {{ position: number }} position
+ * @returns {T}
  */
 function collectASequenceOfCodePointsFast (char, input, position) {
   const idx = input.indexOf(char, position.position)

lib/formdata/parser.js

@@ -14,6 +14,7 @@ const { TextSearch } = require('./textsearch')
 const {
   parseMIMEType,
   collectASequenceOfCodePoints,
+  collectASequenceOfCodePointsFast,
   stringPercentDecode
 } = require('../fetch/dataURL')
 
@@ -519,8 +520,8 @@ class FormDataParser extends Writable {
     const position = { position: 0 }
 
     while (position.position < buffer.length) {
-      const nameBuffer = collectASequenceOfCodePoints(
-        (char) => char !== chars[':'],
+      const nameBuffer = collectASequenceOfCodePointsFast(
+        chars[':'],
         buffer,
         position
       )
@@ -557,8 +558,8 @@ class FormDataParser extends Writable {
 
         // Go to the next header if one is available. Headers are split by \r\n,
         // so we skip all characters until the sequence is found.
-        collectASequenceOfCodePoints(
-          (char) => char !== chars.cr && buffer[position.position + 1] !== chars.lf,
+        collectASequenceOfCodePointsFast(
+          '\r\n',
           buffer,
           position
         )
@@ -595,8 +596,8 @@ class FormDataParser extends Writable {
       }
 
       if (name !== 'content-disposition') {
-        collectASequenceOfCodePoints(
-          (char) => char !== chars.cr && buffer[position.position + 1] !== chars.lf,
+        collectASequenceOfCodePointsFast(
+          '\r\n',
           buffer,
           position
         )

lib/formdata/util.js

@@ -1,6 +1,6 @@
 'use strict'
 
-const { collectASequenceOfCodePoints } = require('../fetch/dataURL')
+const { collectASequenceOfCodePointsFast } = require('../fetch/dataURL')
 
 /**
  * Collect a string inside of quotes. Unlike
@@ -13,8 +13,8 @@ function collectHTTPQuotedStringLenient (str) {
     return str
   }
 
-  return collectASequenceOfCodePoints(
-    (char) => char.charCodeAt(0) !== 0x22, // "
+  return collectASequenceOfCodePointsFast(
+    '"',
     str,
     { position: 1 }
   )

package.json

@@ -46,7 +46,7 @@
     "build:wasm": "node build/wasm.js --docker",
     "lint": "standard | snazzy",
     "lint:fix": "standard --fix | snazzy",
-    "test": "npm run test:tap && npm run test:node-fetch && npm run test:fetch && npm run test:cookies && npm run test:wpt && npm run test:websocket && npm run test:jest && tsd",
+    "test": "npm run test:tap && npm run test:node-fetch && npm run test:fetch && npm run test:cookies && npm run test:busboy && npm run test:wpt && npm run test:websocket && npm run test:jest && tsd",
     "test:busboy": "node scripts/verifyVersion 18 || node test/busboy/test.js",
     "test:cookies": "node scripts/verifyVersion 16 || tap test/cookie/*.js",
     "test:node-fetch": "node scripts/verifyVersion.js 16 || mocha test/node-fetch",