quic: Improve test coverage

Author: martenrichter

src/quic/streams.cc

@@ -1433,6 +1433,17 @@ JS_METHOD_IMPL(DataQueueFeeder::Error) {
   feeder->DrainAndClose();
 }
 
+JS_METHOD_IMPL(DataQueueFeeder::AddFakePull) {
+  DataQueueFeeder* feeder;
+  ASSIGN_OR_RETURN_UNWRAP(&feeder, args.This());
+  // this adds a fake pull for testing code, not to be used anywhere else
+  Next dummyNext = [](int, const DataQueue::Vec*, size_t, bob::Done) {
+    // intentionally empty
+  };
+  feeder->addPendingPull(PendingPull(std::move(dummyNext)));
+  feeder->tryWakePulls();
+}
+
 JS_CONSTRUCTOR_IMPL(DataQueueFeeder, dataqueuefeeder_constructor_template, {
   auto isolate = env->isolate();
   JS_NEW_CONSTRUCTOR();
@@ -1441,6 +1452,7 @@ JS_CONSTRUCTOR_IMPL(DataQueueFeeder, dataqueuefeeder_constructor_template, {
   SetProtoMethod(isolate, tmpl, "error", Error);
   SetProtoMethod(isolate, tmpl, "submit", Submit);
   SetProtoMethod(isolate, tmpl, "ready", Ready);
+  SetProtoMethod(isolate, tmpl, "addFakePull", AddFakePull);
 })
 
 void DataQueueFeeder::InitPerIsolate(IsolateData* data,
@@ -1461,6 +1473,7 @@ void DataQueueFeeder::RegisterExternalReferences(
   registry->Register(Submit);
   registry->Register(Error);
   registry->Register(Ready);
+  registry->Register(AddFakePull);
 }
 
 }  // namespace node

src/quic/streams.h

@@ -452,6 +452,7 @@ class DataQueueFeeder final : public AsyncWrap {
   JS_METHOD(Submit);
   JS_METHOD(Error);
   JS_METHOD(Ready);
+  JS_METHOD(AddFakePull);
 
  private:
   std::shared_ptr<DataQueue> dataQueue_;

test/parallel/test-quic-internal-dataqueuefeeder.mjs

@@ -0,0 +1,40 @@
+// Flags: --expose-internals --experimental-quic --no-warnings
+import { hasQuic, skip } from '../common/index.mjs';
+import {
+  rejects,
+} from 'node:assert';
+
+if (!hasQuic) {
+  skip('QUIC is not enabled');
+}
+
+const { internalBinding } = (await import('internal/test/binding')).default;
+
+const {
+  DataQueueFeeder,
+} = internalBinding('quic');
+
+
+const feeder = new DataQueueFeeder();
+feeder.addFakePull();
+await feeder.ready();
+let lastprom = feeder.submit(new Uint8Array([1, 2, 3]), false);
+feeder.addFakePull();
+await lastprom;
+lastprom = feeder.submit(new Uint16Array([1, 2, 3]), false);
+feeder.addFakePull();
+await lastprom;
+lastprom = feeder.submit(new Uint32Array([1, 2, 3]), false);
+feeder.addFakePull();
+await lastprom;
+lastprom = feeder.submit(new Uint8Array([1, 2, 3]).buffer, false);
+feeder.addFakePull();
+await lastprom;
+await rejects(async () => feeder.submit({}, false), {
+  code: 'ERR_INVALID_ARG_TYPE',
+});
+await rejects(async () => feeder.submit([], false), {
+  code: 'ERR_INVALID_ARG_TYPE',
+});
+await feeder.submit(undefined, true);
+feeder.error(new Error('Can we send an error'));

test/parallel/test-quic-server-to-client-unidirectional.mjs

@@ -45,7 +45,7 @@ const KNOWN_BYTES_LONG = [
   createBytesChunk(60000), // 96, 234
   createBytesChunk(12), // 0, 12
   createBytesChunk(50000), // 195, 80
-  createBytesChunk(1600), // 6, 64
+  createBytesChunk(1600).buffer, // 6, 64 we use buffer here to increae test coverage
   createBytesChunk(20000), // 78, 32
   createBytesChunk(30000), // 117, 48
 ];