quic: Fix linting 3

Author: martenrichter

src/dataqueue/queue.cc

@@ -450,9 +450,11 @@ class NonIdempotentDataQueueReader final
                             status == bob::Status::STATUS_EOS,
                         vecs == nullptr && count == 0);
           if (status == bob::Status::STATUS_EOS) {
-            current_reader_ = nullptr; // must be done before erasing the entries
-            // as FdEntry's and FeederEntry's reader hold a pointer to the entry!
-            // and FeederEntry invoke it in destructor
+            current_reader_ = nullptr;
+            // must be done before erasing the entries
+            // as FdEntry's and FeederEntry's reader hold
+            // a pointer to the entry! and FeederEntry
+            // invoke it in destructor
             data_queue_->entries_.erase(data_queue_->entries_.begin());
             ended_ = data_queue_->entries_.empty();
             if (!ended_) status = bob::Status::STATUS_CONTINUE;

src/quic/session.cc

@@ -542,7 +542,7 @@ struct Session::Impl final : public MemoryRetainer {
         remote_address_(config.remote_address),
         application_(SelectApplication(session, config_)),
         timer_(session_->env(), [this] {
-          auto impl = session_->impl_; // we hold a reference to ourself,
+          auto impl = session_->impl_;  // we hold a reference to ourself,
           // as the reference from session to us may go away
           // while we call OnTimeout
           session_->OnTimeout();
@@ -565,15 +565,15 @@ struct Session::Impl final : public MemoryRetainer {
     // we hold a reference to ourself,
     // as the reference from session to us may go away
     // while we destroy streams
-    auto impl = session_->impl_;  
+    auto impl = session_->impl_;
 
     // Iterate through all of the known streams and close them. The streams
     // will remove themselves from the Session as soon as they are closed.
     // Note: we create a copy because the streams will remove themselves
     // while they are cleaning up which will invalidate the iterator.
     StreamsMap streams = streams_;
     for (auto& stream : streams) stream.second->Destroy(last_error_);
-    DCHECK(streams_.empty()); // do not check our local copy
+    DCHECK(streams_.empty());  // do not check our local copy
 
     // Clear the pending streams.
     while (!pending_bidi_stream_queue_.IsEmpty()) {
@@ -1410,7 +1410,8 @@ void Session::Close(CloseMethod method) {
 
   // This is done already in the implmentation
   // STAT_RECORD_TIMESTAMP(Stats, closing_at);
-  // The next line would be prevent, that close of the implementation is executed!
+  // The next line would prevent,
+  // that close of the implementation is executed!
   // impl_->state_->closing = 1;
 
   // With both the DEFAULT and SILENT options, we will proceed to closing
@@ -1459,12 +1460,15 @@ void Session::Close(CloseMethod method) {
 }
 
 void Session::FinishClose() {
-  if (impl_->state_->finish_closing) return; // we were already called, avoids calling it twice
+  if (impl_->state_->finish_closing) return;
+  // we were already called, avoids calling it twice
   impl_->state_->finish_closing = 1;
-  // FinishClose() should be called only after, and as a result of, Close()
+  // FinishClose() should be called only after,
+  // and as a result of, Close()
   // being called first.
   DCHECK(!is_destroyed());
-  // The next line does not make sense, as in the implementation is also checking if closing is not in progress
+  // The next line does not make sense, as in the implementation
+  // is also checking if closing is not in progress
   // DCHECK(impl_->state_->closing);
 
   // If impl_->Close() returns true, then the session can be destroyed
@@ -1479,11 +1483,12 @@ void Session::FinishClose() {
 }
 
 void Session::Destroy() {
-  // Destroy() should be called only after, and as a result of, Close()
+  // Destroy() should be called only after,
+  // and as a result of, Close()
   // being called first.
   DCHECK(impl_);
   DCHECK(impl_->state_->closing);
-  Debug(this, "Session destroyed");  
+  Debug(this, "Session destroyed");
   if (qlog_stream_ || keylog_stream_) {
     env()->SetImmediate(
         [qlog = qlog_stream_, keylog = keylog_stream_](Environment*) {
@@ -2109,7 +2114,8 @@ void Session::RemoveStream(stream_id id) {
   // returns.
   if (impl_->state_->closing && impl_->state_->graceful_close) {
     FinishClose();
-    // CHECK(is_destroyed()); // this will not work, our this pointer may not be valid anymore!
+    // CHECK(is_destroyed());
+    // this will not work, our this pointer may not be valid anymore!
   }
 }
 

src/quic/session.h

@@ -497,9 +497,11 @@ class Session final : public AsyncWrap, private SessionTicket::AppData::Source {
 
   Side side_;
   ngtcp2_mem allocator_;
-  std::shared_ptr<Impl> impl_; // we need to have a shared ptr, there are situations
-  // where Impl calls the session and the session resets this pointer to Impl,
-  // in this case we need to hold a local shared ptr to prevent use after free
+  std::shared_ptr<Impl> impl_;  // we need to have a shared ptr,
+  //  there are situations, where Impl calls the session and
+  // the session resets this pointer to Impl,
+  // in this case we need to hold a local shared ptr
+  // to prevent use after free
   QuicConnectionPointer connection_;
   std::unique_ptr<TLSSession> tls_session_;
   BaseObjectPtr<LogStream> qlog_stream_;

src/quic/streams.cc

@@ -1349,7 +1349,9 @@ void DataQueueFeeder::tryWakePulls() {
 
 void DataQueueFeeder::DrainAndClose() {
   if (done) return;
-  done = true; // do not do this several time, and note, it may be called several times.
+  done = true;
+  // do not do this several time, and note,
+  // it may be called several times.
   while (!pendingPulls_.empty()) {
     auto& pending = pendingPulls_.front();
     auto pop = OnScopeLeave([this] { pendingPulls_.pop_front(); });
@@ -1393,7 +1395,7 @@ JS_METHOD_IMPL(DataQueueFeeder::Submit) {
   if (args[1]->IsBoolean() && args[1].As<v8::Boolean>()->Value()) {
     done = true;
   }
-  if (!args[0].IsEmpty() && 
+  if (!args[0].IsEmpty() &&
       !args[0]->IsUndefined() && !args[0]->IsNull()) {
     CHECK_GT(feeder->pendingPulls_.size(), 0);
     auto chunk = args[0];