quic: Move DataQueueFeeder to class body

Author: martenrichter

src/quic/streams.h

@@ -405,8 +405,31 @@ class DataQueueFeeder final : public AsyncWrap {
 
   void setDataQueue(std::shared_ptr<DataQueue> queue) { dataQueue_ = queue; }
 
-  void tryWakePulls();
-  void DrainAndClose();
+  void tryWakePulls() {
+    if (!readFinish_.IsEmpty()) {
+      Local<Promise::Resolver> resolver = readFinish_.Get(env()->isolate());
+      // I do not think, that this can error...
+      (void)resolver->Resolve(env()->context(), v8::True(env()->isolate()));
+      readFinish_.Reset();
+    }
+  }
+
+  void DrainAndClose() {
+    if (done) return;
+    done = true;
+    // do not do this several time, and note,
+    // it may be called several times.
+    while (!pendingPulls_.empty()) {
+      auto& pending = pendingPulls_.front();
+      auto pop = OnScopeLeave([this] { pendingPulls_.pop_front(); });
+      pending.next(bob::STATUS_EOS, nullptr, 0, [](uint64_t) {});
+    }
+    if (!readFinish_.IsEmpty()) {
+      Local<Promise::Resolver> resolver = readFinish_.Get(env()->isolate());
+      (void)resolver->Resolve(env()->context(), v8::False(env()->isolate()));
+      readFinish_.Reset();
+    }
+  }
 
   struct PendingPull {
     Next next;
@@ -436,32 +459,6 @@ class DataQueueFeeder final : public AsyncWrap {
   bool done = false;
 };
 
-void DataQueueFeeder::tryWakePulls() {
-  if (!readFinish_.IsEmpty()) {
-    Local<Promise::Resolver> resolver = readFinish_.Get(env()->isolate());
-    // I do not think, that this can error...
-    (void)resolver->Resolve(env()->context(), v8::True(env()->isolate()));
-    readFinish_.Reset();
-  }
-}
-
-void DataQueueFeeder::DrainAndClose() {
-  if (done) return;
-  done = true;
-  // do not do this several time, and note,
-  // it may be called several times.
-  while (!pendingPulls_.empty()) {
-    auto& pending = pendingPulls_.front();
-    auto pop = OnScopeLeave([this] { pendingPulls_.pop_front(); });
-    pending.next(bob::STATUS_EOS, nullptr, 0, [](uint64_t) {});
-  }
-  if (!readFinish_.IsEmpty()) {
-    Local<Promise::Resolver> resolver = readFinish_.Get(env()->isolate());
-    (void)resolver->Resolve(env()->context(), v8::False(env()->isolate()));
-    readFinish_.Reset();
-  }
-}
-
 }  // namespace node
 
 #endif  // defined(NODE_WANT_INTERNALS) && NODE_WANT_INTERNALS