Skip to content

Commit dd95409

Browse files
authored
Merge pull request #2258 from orgads/yarn-update
chore: Simplify yarn and alpine version update
2 parents cc626c1 + 61380fa commit dd95409

File tree

1 file changed

+2
-8
lines changed

1 file changed

+2
-8
lines changed

update.sh

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,6 @@ fi
6666
arch=$(get_arch)
6767

6868
if [ "${SKIP}" != true ]; then
69-
alpine_version=$(get_config "./" "alpine_version")
7069
yarnVersion="$(curl -sSL --compressed https://yarnpkg.com/latest-version)"
7170
fi
7271

@@ -135,9 +134,6 @@ function update_node_version() {
135134
sed -Ei -e 's/^FROM (.*)/FROM '"$fromprefix"'\1/' "${dockerfile}-tmp"
136135
sed -Ei -e 's/^(ENV NODE_VERSION ).*/\1'"${nodeVersion}"'/' "${dockerfile}-tmp"
137136

138-
currentYarnVersion="$(grep "ENV YARN_VERSION" "${dockerfile}" | cut -d' ' -f3)"
139-
sed -Ei -e 's/^(ENV YARN_VERSION ).*/\1'"${currentYarnVersion}"'/' "${dockerfile}-tmp"
140-
141137
# shellcheck disable=SC1004
142138
new_line=' \\\
143139
'
@@ -172,11 +168,9 @@ function update_node_version() {
172168
if diff -q "${dockerfile}-tmp" "${dockerfile}" > /dev/null; then
173169
echo "${dockerfile} is already up to date!"
174170
else
175-
if [ "${SKIP}" = true ]; then
176-
# Get the currently used Yarn version
177-
yarnVersion="$(grep "ENV YARN_VERSION" "${dockerfile}" | cut -d' ' -f3)"
171+
if [ "${SKIP}" != true ]; then
172+
sed -Ei -e 's/^(ENV YARN_VERSION ).*/\1'"${yarnVersion}"'/' "${dockerfile}-tmp"
178173
fi
179-
sed -Ei -e 's/^(ENV YARN_VERSION ).*/\1'"${yarnVersion}"'/' "${dockerfile}-tmp"
180174
echo "${dockerfile} updated!"
181175
fi
182176

0 commit comments

Comments
 (0)