Merge pull request #59 from nodegui/fix/win-not-closing

Fix/win not closing

Author: a7ul

package.json

@@ -16,7 +16,7 @@
   },
   "scripts": {
     "build": "tsc",
-    "dev": "tsc && qode ./dist/demo.js",
+    "dev": "tsc && qode --inspect ./dist/demo.js",
     "docs": "typedoc"
   },
   "dependencies": {

src/components/Image/RNImage.ts

@@ -21,7 +21,7 @@ const setImageProps = (
       const pixMap = new QPixmap(imageUrl);
       widget.setPixmap(pixMap);
       const size = widget.size();
-      widget.scalePixmap(size.width, size.height);
+      widget.scalePixmap(size.width(), size.height());
     },
     set aspectRatioMode(mode: AspectRatioMode) {
       widget.setAspectRatioMode(mode);

src/components/Image/index.ts

@@ -18,7 +18,7 @@ class ImageConfig extends ComponentConfig {
     widget.setProps(newProps, {});
     widget.addEventListener(QLabelEvents.Resize, () => {
       const size = widget.size();
-      widget.scalePixmap(size.width, size.height);
+      widget.scalePixmap(size.width(), size.height());
     });
     return widget;
   }

src/components/View/RNView.ts

@@ -65,7 +65,7 @@ export interface ViewProps extends RNProps {
   /**
    * This property holds the level of opacity for the window. [QWidget: setWindowOpacity](https://docs.nodegui.org/docs/api/NodeWidget#widgetsetwindowopacityopacity)
    */
-  windowOpacity?: Number;
+  windowOpacity?: number;
   /**
    * Sets the window title property. [QWidget: setWindowTitle](https://docs.nodegui.org/docs/api/NodeWidget#widgetsetwindowtitletitle)
    */
@@ -146,7 +146,7 @@ export const setViewProps = (
     set enabled(enable: boolean) {
       widget.setEnabled(enable);
     },
-    set windowOpacity(opacity: Number) {
+    set windowOpacity(opacity: number) {
       widget.setWindowOpacity(opacity);
     },
     set windowTitle(title: string) {

src/reconciler/index.ts

@@ -102,6 +102,9 @@ const HostConfig: Reconciler.HostConfig<
   },
   removeChildFromContainer: (container, child) => {
     container.delete(child);
+    if (child.close) {
+      child.close();
+    }
   },
   prepareUpdate: function(
     instance,
@@ -149,6 +152,9 @@ const HostConfig: Reconciler.HostConfig<
   },
   removeChild: (parent: RNWidget, child: NodeWidget) => {
     parent.removeChild(child);
+    if (child.close) {
+      child.close();
+    }
   },
   commitTextUpdate: (textInstance, oldText, newText) => {
     //noop since we manage all text using Text component