Skip to content

Commit 0f5aad4

Browse files
authored
Merge pull request #17 from Nicify/master
Remove scheduleDeferredCallback and its associated methods from the hostconfig ...
2 parents 531e39a + 78cfd03 commit 0f5aad4

File tree

3 files changed

+11
-22
lines changed

3 files changed

+11
-22
lines changed

package-lock.json

Lines changed: 7 additions & 7 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -14,20 +14,19 @@
1414
"dev": "tsc && qode ./dist/demo.js"
1515
},
1616
"dependencies": {
17-
"react-reconciler": "^0.20.4"
17+
"react-reconciler": "^0.21.0"
1818
},
1919
"peerDependencies": {
2020
"@nodegui/nodegui": "*",
2121
"@nodegui/qode": "*",
22-
"react": "*"
22+
"react": "16.9.0"
2323
},
2424
"devDependencies": {
2525
"@nodegui/nodegui": "^0.1.5",
2626
"@types/node": "^12.0.10",
2727
"@types/react-reconciler": "^0.18.0",
28-
"@types/scheduler": "^0.12.1",
2928
"prettier": "^1.18.2",
30-
"react": "^16.8.6",
29+
"react": "^16.9.0",
3130
"typescript": "^3.5.2"
3231
}
33-
}
32+
}

src/reconciler/index.ts

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -215,16 +215,6 @@ const HostConfig: Reconciler.HostConfig<
215215
"unhideTextInstance called when platform doesnt have host level text"
216216
);
217217
},
218-
// Fiber stuff I think
219-
schedulePassiveEffects: scheduler.unstable_scheduleCallback, // For supporting useEffect hook,
220-
cancelPassiveEffects: scheduler.unstable_cancelCallback, // For supporting useEffect hooks - cancellation
221-
scheduleDeferredCallback: scheduler.unstable_scheduleCallback,
222-
cancelDeferredCallback: scheduler.unstable_cancelCallback,
223-
shouldYield: () => {
224-
// When can renderer just rest and not do any work. Basically if shouldYield returns true the renderer would just sleep and pause.
225-
// This method will be continuously polled by the reconciler to check if renderer should resume.
226-
return false;
227-
},
228218
scheduleTimeout: setTimeout,
229219
cancelTimeout: clearTimeout,
230220
noTimeout: -1,

0 commit comments

Comments
 (0)