Skip to content

Commit 042a559

Browse files
author
slidinghotdog
committed
Add geometry prop to View instead of Window
1 parent ef7841e commit 042a559

File tree

3 files changed

+1179
-15
lines changed

3 files changed

+1179
-15
lines changed

src/components/View/index.ts

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,10 +6,17 @@ import {
66
} from "@nodegui/nodegui";
77
import { registerComponent } from "../config";
88

9+
type Geometry = {
10+
x: number;
11+
y: number;
12+
width: number;
13+
height: number;
14+
};
915
export interface ListenerMap {
1016
[key: string]: (payload?: any) => void;
1117
}
1218
export interface ViewProps {
19+
geometry?: Geometry;
1320
id?: string;
1421
style?: string; // Inline style from NodeGui
1522
styleSheet?: string;
@@ -29,6 +36,14 @@ export const setProps = (
2936
oldProps: ViewProps
3037
) => {
3138
const setter: ViewProps = {
39+
set geometry(geometry: Geometry) {
40+
widget.setGeometry(
41+
geometry.x,
42+
geometry.y,
43+
geometry.width,
44+
geometry.height
45+
);
46+
},
3247
set visible(shouldShow: boolean) {
3348
shouldShow ? widget.show() : widget.hide();
3449
},

src/components/Window/index.ts

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -6,18 +6,11 @@ type WindowSize = {
66
width: number;
77
height: number;
88
};
9-
type Geometry = {
10-
x: number;
11-
y: number;
12-
width: number;
13-
height: number;
14-
};
159
interface WindowProps extends ViewProps {
1610
viewProps?: ViewProps;
1711
fixedSize?: WindowSize | null;
1812
minSize?: WindowSize;
1913
maxSize?: WindowSize;
20-
geometry?: Geometry;
2114
}
2215

2316
const setProps = (
@@ -39,14 +32,6 @@ const setProps = (
3932
window.setMaximumSize(maxSize.width, maxSize.height);
4033
}
4134
},
42-
set geometry(geometry: Geometry) {
43-
window.setGeometry(
44-
geometry.x,
45-
geometry.y,
46-
geometry.width,
47-
geometry.height
48-
);
49-
},
5035
set minSize(size: WindowSize) {
5136
window.setMinimumSize(size.width, size.height);
5237
},

0 commit comments

Comments
 (0)