fix missing authorityKeyIdentifier in self-signed certificate #20

Author: erossignon

packages/node-opcua-crypto-test/test/test_create_self_signed_certificate.ts

@@ -25,7 +25,7 @@ import fs from "fs";
 import path from "path";
 import os from "os";
 import util from "util";
-
+import should from "should";
 import x509 from "@peculiar/x509";
 import {
     readCertificate,
@@ -45,7 +45,7 @@ const tmpTestFolder = os.tmpdir();
 describe("creating X509 self-signed certificates", function () {
     this.timeout(100000);
 
-    it("should create a certificate", async () => {
+    it("should create a self-signed certificate", async () => {
         const { privateKey } = await generateKeyPair();
         const { cert } = await createSelfSignedCertificate({
             privateKey,
@@ -67,6 +67,12 @@ describe("creating X509 self-signed certificates", function () {
         info.tbsCertificate.extensions!.keyUsage!.dataEncipherment.should.eql(true);
         info.tbsCertificate.extensions!.keyUsage!.digitalSignature.should.eql(true);
         info.tbsCertificate.extensions!.keyUsage!.cRLSign.should.eql(false);
+
+        should.exist(info.tbsCertificate.extensions!.subjectKeyIdentifier);
+        should.exist(info.tbsCertificate.extensions!.authorityKeyIdentifier);
+        info.tbsCertificate.extensions!.authorityKeyIdentifier!.keyIdentifier!.should.eql(
+            info.tbsCertificate.extensions?.subjectKeyIdentifier
+        );
     });
     it("should create a certificate with alternative names", async () => {
         const { privateKey } = await generateKeyPair();

packages/node-opcua-crypto/source/x509/create_self_signed_certificate.ts

@@ -104,6 +104,7 @@ export async function createSelfSignedCertificate({
                 new x509.ExtendedKeyUsageExtension(keyUsageExtension, true),
                 new x509.KeyUsagesExtension(usages, true),
                 await x509.SubjectKeyIdentifierExtension.create(keys.publicKey),
+                await x509.AuthorityKeyIdentifierExtension.create(keys.publicKey),
                 new x509.SubjectAlternativeNameExtension(alternativeNameExtensions),
             ],
         },