Skip to content

Commit fabca1f

Browse files
dnaglnmklotas
authored andcommitted
Fix JSON deserialization issue (#53)
* Added ClosedBy clas * Changed ClosedBy type from string to ClosedBy class
1 parent fa9198a commit fabca1f

File tree

3 files changed

+31
-2
lines changed

3 files changed

+31
-2
lines changed
Lines changed: 28 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,28 @@
1+
using System;
2+
using System.Collections.Generic;
3+
using System.Text;
4+
using Newtonsoft.Json;
5+
6+
namespace GitLabApiClient.Models.Issues.Responses
7+
{
8+
public sealed class ClosedBy : ModifiableObject
9+
{
10+
[JsonProperty("active")]
11+
public string State;
12+
13+
[JsonProperty("web_url")]
14+
public string WebUrl;
15+
16+
[JsonProperty("avatar_url")]
17+
public string AvatarUrl;
18+
19+
[JsonProperty("username")]
20+
public string Username;
21+
22+
[JsonProperty("id")]
23+
public string Id;
24+
25+
[JsonProperty("name")]
26+
public string Name;
27+
}
28+
}

src/GitLabApiClient/Models/Issues/Responses/Issue.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ public sealed class Issue : ModifiableObject
3838
public DateTime? ClosedAt { get; set; }
3939

4040
[JsonProperty("closed_by")]
41-
public string ClosedBy { get; set; }
41+
public ClosedBy ClosedBy { get; set; }
4242

4343
[JsonProperty("title")]
4444
public string Title { get; set; }

src/GitLabApiClient/Models/MergeRequests/Responses/MergeRequest.cs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
using System;
22
using System.Collections.Generic;
3+
using GitLabApiClient.Models.Issues.Responses;
34
using GitLabApiClient.Models.Milestones.Responses;
45
using Newtonsoft.Json;
56

@@ -62,7 +63,7 @@ public sealed class MergeRequest : ModifiableObject
6263
public DateTime? ClosedAt { get; set; }
6364

6465
[JsonProperty("closed_by")]
65-
public string ClosedBy { get; set; }
66+
public ClosedBy ClosedBy { get; set; }
6667

6768
[JsonProperty("target_branch")]
6869
public string TargetBranch { get; set; }

0 commit comments

Comments
 (0)