Skip to content

Electron Builder does not include dependencies prefixed with "node:" #2000

@trek-eric

Description

@trek-eric

Describe the bug
These dependencies were not found:

  • node:http in ./node_modules/@azure/core-rest-pipeline/dist/commonjs/nodeHttpClient.js
  • node:https in ./node_modules/@azure/core-rest-pipeline/dist/commonjs/nodeHttpClient.js
  • node:os in ./node_modules/@azure/core-rest-pipeline/dist/commonjs/util/userAgentPlatform.js, ./node_modules/@azure/logger/dist/commonjs/log.js
  • node:process in ./node_modules/@azure/core-rest-pipeline/dist/commonjs/util/userAgentPlatform.js, ./node_modules/@azure/logger/dist/commonjs/log.js
  • node:stream in ./node_modules/@azure/core-rest-pipeline/dist/commonjs/nodeHttpClient.js, ./node_modules/@azure/core-rest-pipeline/dist/commonjs/util/concat.js
  • node:util in ./node_modules/@azure/core-rest-pipeline/dist/commonjs/util/inspect.js, ./node_modules/@azure/logger/dist/commonjs/log.js
  • node:zlib in ./node_modules/@azure/core-rest-pipeline/dist/commonjs/nodeHttpClient.js

To install them, you can run: npm install --save node:http node:https node:os node:process node:stream node:util node:zlib
ERROR Build failed with errors.

To Reproduce
update a working vue app from 16 to 18 that includes a dependency prefixed with "node:" - Azure's appinsights is a great example

nvm use 16
vue create app
cd app
vue add electron-builder
npm run electron:serve (works!)
nvm use 18
npm update --save
npm install --save applicationinsights
add to background.js :

let appInsights = require("applicationinsights");
console.log(appInsights)

Expected behavior
My understanding is prefixed modules with node:modulename should work fine - i am expecting the builder to build and include the dependencies as it did with node v.16

Environment (please complete the following information):
eg: https://github.com/trek-eric/vue_app_18 - note the commits to see the working vs breaking change

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions