PR 36: Moved Created Date edit up to before save as recommneded by the product team +semver:patch

MrHinsh · MrHinsh · commit f92438b7ebf0 · 2016-08-16T01:34:18.000Z
- Moved Created Date edit up to before save as recommneded by the product team
diff --git a/TfsWitMigrator.Core/Execution/MigrationContext/WorkItemMigrationContext.cs b/TfsWitMigrator.Core/Execution/MigrationContext/WorkItemMigrationContext.cs
@@ -85,16 +85,15 @@ internal override void InternalExecute()
 
                         try
                         {
+                            newwit.Fields["System.CreatedDate"].Value = sourceWI.Fields["System.CreatedDate"].Value;
                             newwit.Save();
                             Trace.WriteLine(string.Format("...Saved as {0}", newwit.Id));
-                            newwit.Fields["System.CreatedDate"].Value = sourceWI.Fields["System.CreatedDate"].Value;
-                            Trace.WriteLine(string.Format("...And Date Created Updated"));
                             if (sourceWI.Fields.Contains(me.ReflectedWorkItemIdFieldName))
                             {
                                 sourceWI.Fields[me.ReflectedWorkItemIdFieldName].Value = targetStore.CreateReflectedWorkItemId(newwit);
                             }
-                            newwit.Save();
-
+                            sourceWI.Save();
+                            Trace.WriteLine(string.Format("...and Source Updated {0}", sourceWI.Id));
                         }
                         catch (Exception ex)
                         {

Original file line number	Diff line number	Diff line change
`@@ -85,16 +85,15 @@ internal override void InternalExecute()`
`85`	`85`
`86`	`86`	`try`
`87`	`87`	`{`
	`88`	`+ newwit.Fields["System.CreatedDate"].Value = sourceWI.Fields["System.CreatedDate"].Value;`
`88`	`89`	`newwit.Save();`
`89`	`90`	`Trace.WriteLine(string.Format("...Saved as {0}", newwit.Id));`
`90`		`- newwit.Fields["System.CreatedDate"].Value = sourceWI.Fields["System.CreatedDate"].Value;`
`91`		`- Trace.WriteLine(string.Format("...And Date Created Updated"));`
`92`	`91`	`if (sourceWI.Fields.Contains(me.ReflectedWorkItemIdFieldName))`
`93`	`92`	`{`
`94`	`93`	`sourceWI.Fields[me.ReflectedWorkItemIdFieldName].Value = targetStore.CreateReflectedWorkItemId(newwit);`
`95`	`94`	`}`
`96`		`- newwit.Save();`
`97`		`-`
	`95`	`+ sourceWI.Save();`
	`96`	`+ Trace.WriteLine(string.Format("...and Source Updated {0}", sourceWI.Id));`
`98`	`97`	`}`
`99`	`98`	`catch (Exception ex)`
`100`	`99`	`{`