Skip to content

Commit 1bdb085

Browse files
authored
Merge pull request python-trio#1084 from njsmith/flag-pypy-coverage
Sort out coverage issues on pypy3
2 parents 07af2f8 + 6c232ae commit 1bdb085

File tree

1 file changed

+15
-5
lines changed

1 file changed

+15
-5
lines changed

ci.sh

Lines changed: 15 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -124,11 +124,21 @@ else
124124

125125
# Disable coverage on 3.8 until we run 3.8 on Windows CI too
126126
# https://github.com/python-trio/trio/pull/784#issuecomment-446438407
127-
if [[ "$(python -V)" != Python\ 3.8* ]]; then
128-
# Disable coverage on pypy py3.6 nightly for now:
129-
# https://bitbucket.org/pypy/pypy/issues/2943/
130-
if [ "$PYPY_NIGHTLY_BRANCH" != "py3.6" ]; then
131-
bash <(curl -s https://codecov.io/bash) -n "${CODECOV_NAME}"
127+
if [[ "$(python -V)" = Python\ 3.8* ]]; then
128+
true;
129+
# coverage is broken in pypy3 7.1.1, but is fixed in nightly and should be
130+
# fixed in the next release after 7.1.1.
131+
# See: https://bitbucket.org/pypy/pypy/issues/2943/
132+
elif [[ "$TRAVIS_PYTHON_VERSION" = "pypy3" ]]; then
133+
true;
134+
else
135+
# Flag pypy and cpython coverage differently, until it settles down...
136+
FLAG="cpython"
137+
if [[ "$PYPY_NIGHTLY_BRANCH" == "py3.6" ]]; then
138+
FLAG="pypy36nightly"
139+
elif [[ "$(python -V)" == *PyPy* ]]; then
140+
FLAG="pypy36release"
132141
fi
142+
bash <(curl -s https://codecov.io/bash) -n "${CODECOV_NAME}" -F "$FLAG"
133143
fi
134144
fi

0 commit comments

Comments
 (0)