[spotify-player] what approach should I take

[repparw]

Just realized there's something i didnt contemplate.

the same file where theme selected and theme palettes are stored, you can set which elements grab which colors

e.g

[themes.component_style]
selection = { bg = "BrightBlack", modifiers = ["Bold"] }
block_title = { fg = "Magenta" }
playback_track = { fg = "Cyan", modifiers = ["Bold"] }
playback_album = { fg = "Yellow" }
playback_metadata = { fg = "Blue" }
playback_progress_bar = { bg = "BrightBlack", fg = "Green" }
current_playing = { fg = "Green", modifiers = ["Bold"] }
page_desc = { fg = "Cyan", modifiers = ["Bold"] }
table_header = { fg = "Blue" }
border = {}
playback_status = { fg = "Cyan", modifiers = ["Bold"] }
playback_artists = { fg = "Cyan", modifiers = ["Bold"] }
playlist_desc = { fg = "White" }

without these things changed, default on some (most?) themes looks bad

e.g progress bar uses different colors on two elements

this did not happen with the theme i was using till now, so i did not realize it.

Should we let people define the component styles by themselves or should we manage this in the module?

https://mynixos.com/home-manager/option/programs.spotify-player.themes also see example

themes specifically made for spotify-player (see catpuccin) usually set 'em

[repparw]

All components and their defaults

[danth]

IMO it would make sense to manage this in the module. We only avoid this for programs like Waybar, where it's very common for users to design their own layout from scratch (presumably this is not what spotify-player is for).

[repparw]

I ended up using another theme that also didn't have a problem w/ the default settings, like the one I was using before (tokyo night and gruvbox material particularly).

I don't particularly know how to handle this really, because not all theme set those options the same way

[repparw]

The default seems to invert fg and change bg to another shade, that in some themes seems to be same color and some not?

[danth]

That sounds like the application might be generating its own colors, which could be difficult to handle unless there's a way to override it