more in-depth labeling

[awwpotato]

we should consider make these labeling changes:

• automatic labeling for prs (nixpkgs as example)
• labeling by platform e.g. home-manager or overlays
• add style-guide label

I can implement these changes if others agree they are a good idea.
cc: @danth @trueNAHO

[danth]

Personally I would like issues / PRs labeled by the commit convention scope, however that seems impractical, as it would require a new label for every target added (and automating this for renamed / removed targets would be quite difficult). It would probably be the most useful for filtering though.

[awwpotato]

It would probably be the most useful for filtering though.

Filtering by target can already be accomplished by using <target> in:title

[awwpotato]

Also having separate needs: _ and has: _ would be good. Currently the description of the labels only apply to issues. We could also just make the descriptions apply to both prs and issues.

[trueNAHO]

Also having separate needs: _ and has: _ would be good. Currently the description of the labels only apply to issues. We could also just make the descriptions apply to both prs and issues.

What do you mean by these

needs: _ and has: _

labels?

[awwpotato]

yes, adding needs: _ and has: _ labels.

[trueNAHO]

we should consider make these labeling changes:

• automatic labeling for prs (nixpkgs as example)

As pointed out in #1109 (comment), I am unsure about the scope of this automatic labelling.

• labeling by platform e.g. home-manager or overlays
• add style-guide label

These sound good to me. Currently, this would require core maintainers to manually add these labels when appropriate.

[awwpotato]

we should consider make these labeling changes:

• automatic labeling for prs (nixpkgs as example)

As pointed out in #1109 (comment), I am unsure about the scope of this automatic labelling.

I just meant automatically applying new-target or change-target labels to prs.

• labeling by platform e.g. home-manager or overlays
• add style-guide label

These sound good to me. Currently, this would require core maintainers to manually add these labels when appropriate.

Labeling for platforms can also be done automatically for prs

[trueNAHO]

we should consider make these labeling changes:

• automatic labeling for prs (nixpkgs as example)

As pointed out in #1109 (comment), I am unsure about the scope of this automatic labelling.

I just meant automatically applying new-target or change-target labels to prs.

Sounds good to me.

• labeling by platform e.g. home-manager or overlays
• add style-guide label

These sound good to me. Currently, this would require core maintainers to manually add these labels when appropriate.

Labeling for platforms can also be done automatically for prs

That would be neat :)

[awwpotato]

I just meant automatically applying new-target or change-target labels to prs.

seems like this isn't possible because actions/labeler only supports "changed-files" which includes both modification and creation of files

[trueNAHO]

Commit ad7dcca ("ci: add labeler action (#1137)") has been merged and I changed the label colors and descriptions:

I created the labels and will try to improve the color scheme and description of all the labels now.

-- #1137 (review)

Is there anything about the colors or descriptions that should be improved? And should we add more labels, or is the current set of labels good enough?

I assume the current set of labels is pretty extensive.

[awwpotato]

Is there anything about the colors or descriptions that should be improved?

I changed the some of the colors to match nixpkgs more closely, but I'm open to alternatives. We might also consider prefixing labels with their scope e.g. type: chore, topic: nixos so similar labels get placed next to each other.

Should we add more labels, or is the current set of labels good enough?

I think our current set of labels is plenty.

[trueNAHO]

We might also consider prefixing labels with their scope e.g. type: chore, topic: nixos so similar labels get placed next to each other.

Yes, that would be neat, although I am unsure what prefixes to use for some categories. Currently, labels are only grouped by having the same color.

Platforms can be grouped as:

-darwin
-droid
-home-manager
-nixos
+platform: darwin
+platform: droid
+platform: home-manager
+platform: nixos

The following rename would also streamline the addition of future backport labels:

-backport release-24.11
+backport: release-24.11

Note that renaming some labels requires touching the .github/ code.