[HELP] How should I refactor my Lualine config since

[elythh]

Hello, since #2080 my lualine config is outdated and I can't seem to find how to solve the warning it generates

My config file is here.

And here are the warnings:

trace: evaluation warning: Passing a attribute set containing name, icon.icon, extraConfig for `plugins.lualine.settings.sections.lualine_a."[definition 1-entry 1]"' is deprecated, use (attribute set of anything) or raw lua code instead. Definitions:
- In `/nix/store/vw5rfcz9w6s91bv5ypin027bsvbiqff4-source/config/plug/statusline/lualine.nix':
    {
      color = {
        bg = "nil";
        fg = "#BBB6B6";
      };
    ...

trace: evaluation warning: Passing a attribute set containing name, icon.icon, extraConfig for `plugins.lualine.settings.sections.lualine_b."[definition 1-entry 1]"' is deprecated, use (attribute set of anything) or raw lua code instead. Definitions:
- In `/nix/store/vw5rfcz9w6s91bv5ypin027bsvbiqff4-source/config/plug/statusline/lualine.nix':
    {
      color = {
        bg = "nil";
        fg = "#BBB6B6";
      };
    ...

trace: evaluation warning: Passing a attribute set containing name, icon.icon, extraConfig for `plugins.lualine.settings.sections.lualine_b."[definition 1-entry 2]"' is deprecated, use (attribute set of anything) or raw lua code instead. Definitions:
- In `/nix/store/vw5rfcz9w6s91bv5ypin027bsvbiqff4-source/config/plug/statusline/lualine.nix':
    {
      name = "diff";
      separator = {
        left = "";
        right = "";
    ...

trace: evaluation warning: Passing a attribute set containing name, icon.icon, extraConfig for `plugins.lualine.settings.sections.lualine_c."[definition 1-entry 1]"' is deprecated, use (attribute set of anything) or raw lua code instead. Definitions:
- In `/nix/store/vw5rfcz9w6s91bv5ypin027bsvbiqff4-source/config/plug/statusline/lualine.nix':
    {
      color = {
        bg = "nil";
        fg = "#B66467";
      };
    ...

trace: evaluation warning: Passing a attribute set containing name, icon.icon, extraConfig for `plugins.lualine.settings.sections.lualine_y."[definition 1-entry 1]"' is deprecated, use (attribute set of anything) or raw lua code instead. Definitions:
- In `/nix/store/vw5rfcz9w6s91bv5ypin027bsvbiqff4-source/config/plug/statusline/lualine.nix':
    {
      extraConfig = {
        icon_only = true;
      };
      name = "filetype";
    ...

trace: evaluation warning: Passing a attribute set containing name, icon.icon, extraConfig for `plugins.lualine.settings.sections.lualine_y."[definition 1-entry 2]"' is deprecated, use (attribute set of anything) or raw lua code instead. Definitions:
- In `/nix/store/vw5rfcz9w6s91bv5ypin027bsvbiqff4-source/config/plug/statusline/lualine.nix':
    {
      color = {
        bg = "nil";
        fg = "#E8E3E3";
      };
    ...

trace: evaluation warning: Passing a attribute set containing name, icon.icon, extraConfig for `plugins.lualine.settings.sections.lualine_z."[definition 1-entry 1]"' is deprecated, use (attribute set of anything) or raw lua code instead. Definitions:
- In `/nix/store/vw5rfcz9w6s91bv5ypin027bsvbiqff4-source/config/plug/statusline/lualine.nix':
    {
      color = {
        bg = "nil";
        fg = "#8C977D";
      };
    ...

Removing the name attribute solves some of them but it also breaks my config.

Thanks a lot for your help !

[khaneliman]

name -> __unkeyed
icon.icon -> icon.__unkeyed
extraConfig just flatten into the component config

Here's my personal migration khaneliman/khanelivim@0effcf6

[elythh]

Wonderful, thank you !
Here's the commit if anyone need another example.

elythh/nixvim@1b0dc83

[MattSturgeon]

This makes me think we should have a way to pass additional text to transitionType.

Comparing it to mkRebamedOptionModule and mkRemovedOptionModule, renames don't need extra text as the rename itself is simple and obvious. Removals however include "option XYZ is removed" by default, but expect to receive additional migration instructions from the caller.

If the argument list is growing, perhaps using a structured attrs argument would be better?

lib.types.transition = {
  oldType,
  newType,
  coerceFn,
  message ? "",
}: mkOptionType {}

?

[elythh]

Isn't it what transitionType already looks like ?
https://github.com/nix-community/nixvim/blob/54599ad5551c8308f71442e10331a5d752350a3b/lib/deprecation.nix#L63#L95

[MattSturgeon]

No, transitionType's current signature matches coercedTo; it doesn't use structured attr args, and has no way for the user to supply additional text to include in the warning.

[elythh]

Oh I missed the point of your message sorry. You're right, adding an extra text would be nice, Nix types are not the easiest to interpret.

[MattSturgeon]

Tracking this in #2207