bug: password-store sets non-default value

[octvs]

Are you following the right branch?

• My Nixpkgs and Home Manager versions are in sync

Is there an existing issue for this?

• I have searched the existing issues

Issue description

password-store module sets a non-default (but probably common) directory
for the program and it shouldn't.

I tried to find a reasoning behind it but it was added much before without
corresponding discussion so I can't track it further. I used to also have it
set to this exact directory so it never bothered me, but this is not the
default value for pass and we should mimick the program defaults, not user
choices.

This has the potential to break scripts if the corresponding env var is not
sourced on a script or systemd units. Similar issues were also reported here
by users.

I think a saner choice is to stick to the default and offer this with
example on mkOption, which is the behaviour of other modules. For example
gpg, which also have the ability to set its home directory under
XDG_DATA_HOME and perhaps that is more common among users, however the module
doens't enforce it.

Maintainer CC

@pacien

System information

_irrelevant_