Merge pull request #445 from nix-community/various

postgresql.service -> postgresql.target, ruff fixes

Author: Mic92

buildbot_effects/pyproject.toml

@@ -43,8 +43,6 @@ ignore = [
   "ARG001",
   "ARG002",
 
-  # Missing type annotation for `self` in method
-  "ANN101",
   # Dynamically typed expressions (typing.Any)
   "ANN401",
   # Trailing comma missing

buildbot_nix/buildbot_nix/__init__.py

@@ -603,7 +603,6 @@ def nix_eval_config(
             env={},
             name="Evaluate effects",
             command=[
-                # fmt: off
                 "buildbot-effects",
                 "--rev",
                 util.Property("revision"),
@@ -612,7 +611,6 @@ def nix_eval_config(
                 "--repo",
                 util.Property("github.repository.html_url"),
                 "list",
-                # fmt: on
             ],
             flunkOnFailure=True,
             # TODO: support other branches?
@@ -941,7 +939,6 @@ def buildbot_effects_config(
             steps.ShellCommand(
                 name="Run effects",
                 command=[
-                    # fmt: off
                     "buildbot-effects",
                     "--rev",
                     util.Property("revision"),
@@ -953,7 +950,6 @@ def buildbot_effects_config(
                     *secrets_args,
                     "run",
                     util.Property("command"),
-                    # fmt: on
                 ],
                 logEnviron=False,
             ),

flake.lock

@@ -804,7 +804,7 @@ in
     };
 
     systemd.services.buildbot-master = {
-      after = [ "postgresql.service" ];
+      after = [ "postgresql.target" ];
       path = [ pkgs.openssl ];
       serviceConfig = {
         # in master.py we read secrets from $CREDENTIALS_DIRECTORY