File tree Expand file tree Collapse file tree 1 file changed +7
-1
lines changed
buildbot_nix/buildbot_nix Expand file tree Collapse file tree 1 file changed +7
-1
lines changed Original file line number Diff line number Diff line change @@ -39,6 +39,7 @@ class NamespaceData(BaseModel):
39
39
40
40
class RepoData (BaseModel ):
41
41
id : int
42
+ name : str
42
43
name_with_namespace : str
43
44
path : str
44
45
path_with_namespace : str
@@ -86,7 +87,12 @@ def owner(self) -> str:
86
87
87
88
@property
88
89
def name (self ) -> str :
89
- return self .data .name_with_namespace
90
+ # This needs to match what buildbot uses in change hooks to map an incoming change
91
+ # to a project: https://github.com/buildbot/buildbot/blob/master/master/buildbot/www/hooks/gitlab.py#L45
92
+ # I suspect this will result in clashes if you have identically-named projects in
93
+ # different namespaces, as is totally valid in gitlab.
94
+ # Using self.data.name_with_namespace would be more robust.
95
+ return self .data .name
90
96
91
97
@property
92
98
def url (self ) -> str :
You can’t perform that action at this time.
0 commit comments