before close, db will be auto committed

Author: anidotnet

packages/nitrite/lib/src/nitrite_database.dart

@@ -103,7 +103,9 @@ class NitriteDatabase extends Nitrite {
     checkOpened();
     try {
       await _nitriteStore.beforeClose();
-      if (await hasUnsavedChanges) {
+      var shouldAutoCommit =
+          !_nitriteStore.isReadOnly && await hasUnsavedChanges;
+      if (shouldAutoCommit) {
         _log.fine('Unsaved changes detected, committing the changes.');
         await _nitriteStore.commit();
       }
@@ -127,7 +129,11 @@ class NitriteDatabase extends Nitrite {
   Future<void> commit() async {
     checkOpened();
     try {
-      await _nitriteStore.commit();
+      if (!_nitriteStore.isReadOnly) {
+        await _nitriteStore.commit();
+      } else {
+        _log.warning('Cannot commit on read-only database.');
+      }
     } catch (e, stackTrace) {
       throw NitriteIOException('Error occurred while committing the database',
           stackTrace: stackTrace, cause: e);

packages/nitrite/lib/src/store/memory/in_memory_meta.dart

@@ -3,3 +3,4 @@
 Map<String, String> meta = <String, String>{
   "version": "1.1.1",
 };
+  

packages/nitrite/lib/src/store/memory/in_memory_store.dart

@@ -17,7 +17,7 @@ class InMemoryStore extends AbstractNitriteStore<InMemoryConfig> {
   bool get isClosed => _closed;
 
   @override
-  Future<bool> get hasUnsavedChanges async => false;
+  Future<bool> get hasUnsavedChanges async => true;
 
   @override
   bool get isReadOnly => false;

packages/nitrite/test/nitrite_builder_test.dart

@@ -44,7 +44,6 @@ void main() {
           .openOrCreate();
 
       await expectLater(() => db!.getRepository<DateTime>(), returnsNormally);
-      await db!.commit();
     });
   });
 }

packages/nitrite_hive_adapter/lib/src/store/hive_meta.dart

@@ -3,3 +3,4 @@
 Map<String, String> meta = <String, String>{
   "version": "2.2.3",
 };
+  

packages/nitrite_hive_adapter/lib/src/store/hive_store.dart

@@ -67,7 +67,7 @@ class HiveStore extends AbstractNitriteStore<HiveConfig> {
   }
 
   @override
-  Future<bool> get hasUnsavedChanges async => false;
+  Future<bool> get hasUnsavedChanges async => true;
 
   @override
   bool get isClosed => _closed;