Skip to content

Commit 5b855c1

Browse files
cthifacebook-github-bot
authored andcommitted
Remove all imports of <torch/torch.h> from CK extensions (pytorch#4407)
Summary: Pull Request resolved: pytorch#4407 X-link: facebookresearch/FBGEMM#1477 As we are starting to integrate FBGEMM GenAI into torch, we ran into this issue. The problem is that we cannot depend on the libtorch include during the build. It's actually fine to use other things from their own import. In this case, I think we don't actually need it at all? Reviewed By: samanamp Differential Revision: D77393016 fbshipit-source-id: 25e14e7fe4b6c6b9fc1b5c67bad593effbc5ead8
1 parent 170b79d commit 5b855c1

File tree

13 files changed

+0
-13
lines changed

13 files changed

+0
-13
lines changed

fbgemm_gpu/experimental/gen_ai/src/quantize/ck_extensions/bf16_grouped/bf16_grouped_gemm.hip

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@
1818

1919
#include <ATen/ATen.h>
2020
#include <c10/hip/HIPStream.h>
21-
#include <torch/torch.h>
2221

2322
#include "ck/ck.hpp"
2423
#include "ck/tensor_operation/gpu/device/impl/device_grouped_gemm_multiple_d_xdl_cshuffle_tile_loop.hpp"

fbgemm_gpu/experimental/gen_ai/src/quantize/ck_extensions/bf16_grouped/kernels/bf16_grouped_common.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@
1212
#else
1313
#include <c10/cuda/CUDAStream.h>
1414
#endif
15-
#include <torch/torch.h>
1615

1716
#include "ck/ck.hpp"
1817
#include "ck/tensor_operation/gpu/device/gemm_specialization.hpp"

fbgemm_gpu/experimental/gen_ai/src/quantize/ck_extensions/ck_utility.hip

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@
1616

1717
#include <ATen/ATen.h>
1818
#include <c10/hip/HIPStream.h>
19-
#include <torch/torch.h>
2019

2120
#if defined(USE_ROCM)
2221

fbgemm_gpu/experimental/gen_ai/src/quantize/ck_extensions/fp8_blockwise_gemm.hip

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@
1313

1414
#include <ATen/ATen.h>
1515
#include <c10/hip/HIPStream.h>
16-
#include <torch/torch.h>
1716

1817
#include "ck/ck.hpp"
1918
#include "ck/tensor_operation/gpu/device/gemm_specialization.hpp"

fbgemm_gpu/experimental/gen_ai/src/quantize/ck_extensions/fp8_rowwise/fp8_rowwise_gemm.hip

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@
1616

1717
#include <ATen/ATen.h>
1818
#include <c10/hip/HIPStream.h>
19-
#include <torch/torch.h>
2019

2120
#include "kernels/fp8_rowwise_kernel_manifest.h"
2221

fbgemm_gpu/experimental/gen_ai/src/quantize/ck_extensions/fp8_rowwise/kernels/fp8_rowwise_common.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@
1414
#else
1515
#include <c10/cuda/CUDAStream.h>
1616
#endif
17-
#include <torch/torch.h>
1817

1918
#include "ck/ck.hpp"
2019
#include "ck/tensor_operation/gpu/device/gemm_specialization.hpp"

fbgemm_gpu/experimental/gen_ai/src/quantize/ck_extensions/fp8_rowwise_batched/fp8_rowwise_batched_gemm.hip

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@
1616

1717
#include <ATen/ATen.h>
1818
#include <c10/hip/HIPStream.h>
19-
#include <torch/torch.h>
2019

2120
#include "kernels/fp8_rowwise_batched_kernel_manifest.h"
2221

fbgemm_gpu/experimental/gen_ai/src/quantize/ck_extensions/fp8_rowwise_batched/kernels/fp8_rowwise_batched_common.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@
1212
#else
1313
#include <c10/cuda/CUDAStream.h>
1414
#endif
15-
#include <torch/torch.h>
1615

1716
#include "ck/ck.hpp"
1817
#include "ck/tensor_operation/gpu/device/gemm_specialization.hpp"

fbgemm_gpu/experimental/gen_ai/src/quantize/ck_extensions/fp8_rowwise_grouped/fp8_rowwise_grouped_gemm.hip

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@
1919
#include <ATen/ATen.h>
2020
#include <ATen/hip/HIPContext.h>
2121
#include <c10/hip/HIPStream.h>
22-
#include <torch/torch.h>
2322

2423
#include "ck/ck.hpp"
2524
#include "ck/tensor_operation/gpu/device/impl/device_grouped_gemm_multiple_d_xdl_cshuffle_tile_loop.hpp"

fbgemm_gpu/experimental/gen_ai/src/quantize/ck_extensions/fp8_rowwise_grouped/kernels/fp8_rowwise_grouped_common.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@
1212
#else
1313
#include <c10/cuda/CUDAStream.h>
1414
#endif
15-
#include <torch/torch.h>
1615

1716
#include "ck/ck.hpp"
1817
#include "ck/tensor_operation/gpu/device/gemm_specialization.hpp"

0 commit comments

Comments
 (0)