Fix create directory behavior (#983)

Author: iacore

src/nimble.nim

@@ -963,6 +963,7 @@ proc init(options: Options) =
     raise nimbleError("Please install git or mercurial first")
 
   # Determine the package name.
+  let hasProjectName = options.action.projName != ""
   let pkgName =
     if options.action.projName != "":
       options.action.projName
@@ -974,7 +975,7 @@ proc init(options: Options) =
 
   # Determine the package root.
   let pkgRoot =
-    if pkgName == os.getCurrentDir().splitPath.tail:
+    if not hasProjectName:
       os.getCurrentDir()
     else:
       os.getCurrentDir() / pkgName

tests/tester.nim

@@ -5,6 +5,7 @@ import testscommon
 
 # suits imports
 
+import tinitcommand
 import tcheckcommand
 import tcleancommand
 import tdevelopfeature

tests/tinitcommand.nim

@@ -0,0 +1,19 @@
+{.used.}
+
+import unittest, os
+import testscommon
+
+from nimblepkg/common import cd
+
+suite "init":
+  ## https://github.com/nim-lang/nimble/pull/983
+  test "init within directory that is invalid package name will not create new directory":
+    let tempdir = getTempDir() / "a-b"
+    createDir(tempdir)
+    cd(tempdir):
+      let args = ["init"]
+      let (output, exitCode) = execNimbleYes(args)
+      discard output
+      check exitCode == QuitSuccess
+      check not dirExists("a_b")
+      check fileExists("a_b.nimble")